Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move GHContext from gesture-handler to native-stack #2017

Merged
merged 2 commits into from
Jan 22, 2024
Merged

fix: move GHContext from gesture-handler to native-stack #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a63cdec
Fix error about undefined GHContext
tboba Jan 19, 2024
409d655
Move GHContext from gesture-handler to native-stack
tboba Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/gesture-handler/GestureDetectorProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { GHContext } from './context/GHContext';
import { GHContext } from 'react-native-screens';
import ScreenGestureDetector from './ScreenGestureDetector';
import type { GestureProviderProps } from '../native-stack/types';

Expand Down
5 changes: 0 additions & 5 deletions src/gesture-handler/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
/*
* Context
*/
export { GHContext } from './context/GHContext';

/*
* Providers
*/
Expand Down
4 changes: 2 additions & 2 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ export { default as FullWindowOverlay } from './components/FullWindowOverlay';
export { default as NativeScreensModule } from './fabric/NativeScreensModule';

/*
* Gesture Handler
* Contexts
*/
export { GHContext } from './gesture-handler';
export { GHContext } from './native-stack/contexts/GHContext';

/*
* Utils
Expand Down
2 changes: 1 addition & 1 deletion src/gesture-handler/context/GHContext.tsx → src/native-stack/contexts/GHContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { PropsWithChildren } from 'react';
import { GestureProviderProps } from '../../native-stack/types';
import { GestureProviderProps } from '../types';

// context to be used when the user wants full screen swipe (see `gesture-handler` folder in repo)
export const GHContext = React.createContext(
Expand Down
Loading