-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: iOS custom detents & Android form sheets #2045
Commits on Jan 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 49b5ad6 - Browse repository at this point
Copy the full SHA 49b5ad6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 700d46e - Browse repository at this point
Copy the full SHA 700d46eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b4ed40 - Browse repository at this point
Copy the full SHA 7b4ed40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 612ada8 - Browse repository at this point
Copy the full SHA 612ada8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86307aa - Browse repository at this point
Copy the full SHA 86307aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00d50b2 - Browse repository at this point
Copy the full SHA 00d50b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c442b25 - Browse repository at this point
Copy the full SHA c442b25View commit details
Commits on Jan 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 426bee8 - Browse repository at this point
Copy the full SHA 426bee8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3abf7c - Browse repository at this point
Copy the full SHA c3abf7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20a7ae6 - Browse repository at this point
Copy the full SHA 20a7ae6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a0653d - Browse repository at this point
Copy the full SHA 1a0653dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bda77c - Browse repository at this point
Copy the full SHA 6bda77cView commit details -
Revert "Remove RNSModalRootView.kt from main source set"
This reverts commit 1a0653d.
Configuration menu - View commit details
-
Copy full SHA for 2fe8144 - Browse repository at this point
Copy the full SHA 2fe8144View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57f0b43 - Browse repository at this point
Copy the full SHA 57f0b43View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8e9baf - Browse repository at this point
Copy the full SHA f8e9bafView commit details -
Configuration menu - View commit details
-
Copy full SHA for cadde6a - Browse repository at this point
Copy the full SHA cadde6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dafca03 - Browse repository at this point
Copy the full SHA dafca03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dea550 - Browse repository at this point
Copy the full SHA 4dea550View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f47012 - Browse repository at this point
Copy the full SHA 4f47012View commit details
Commits on Jan 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f604827 - Browse repository at this point
Copy the full SHA f604827View commit details -
Configuration menu - View commit details
-
Copy full SHA for 087a938 - Browse repository at this point
Copy the full SHA 087a938View commit details -
Configuration menu - View commit details
-
Copy full SHA for d940324 - Browse repository at this point
Copy the full SHA d940324View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1323f1a - Browse repository at this point
Copy the full SHA 1323f1aView commit details
Commits on Jan 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 52e5839 - Browse repository at this point
Copy the full SHA 52e5839View commit details
Commits on Feb 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7cab9c2 - Browse repository at this point
Copy the full SHA 7cab9c2View commit details
Commits on Feb 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1ca4e3d - Browse repository at this point
Copy the full SHA 1ca4e3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49caf0a - Browse repository at this point
Copy the full SHA 49caf0aView commit details
Commits on Feb 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ab835b8 - Browse repository at this point
Copy the full SHA ab835b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77b9670 - Browse repository at this point
Copy the full SHA 77b9670View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8b3946 - Browse repository at this point
Copy the full SHA f8b3946View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4479c1a - Browse repository at this point
Copy the full SHA 4479c1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72b2631 - Browse repository at this point
Copy the full SHA 72b2631View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1acbdc6 - Browse repository at this point
Copy the full SHA 1acbdc6View commit details
Commits on Feb 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a11db31 - Browse repository at this point
Copy the full SHA a11db31View commit details
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bbfb20f - Browse repository at this point
Copy the full SHA bbfb20fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c7cddc - Browse repository at this point
Copy the full SHA 3c7cddcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a214f19 - Browse repository at this point
Copy the full SHA a214f19View commit details
Commits on Feb 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9d86a34 - Browse repository at this point
Copy the full SHA 9d86a34View commit details
Commits on Feb 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0550367 - Browse repository at this point
Copy the full SHA 0550367View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0753533 - Browse repository at this point
Copy the full SHA 0753533View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97c29ce - Browse repository at this point
Copy the full SHA 97c29ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed8874e - Browse repository at this point
Copy the full SHA ed8874eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d3bdd5 - Browse repository at this point
Copy the full SHA 9d3bdd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6939fc - Browse repository at this point
Copy the full SHA b6939fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88d10d8 - Browse repository at this point
Copy the full SHA 88d10d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3763cf3 - Browse repository at this point
Copy the full SHA 3763cf3View commit details -
Rename updatePresentationStyle to updateFormSheetPresentationStyle
So that the method's name better describes its purpose
Configuration menu - View commit details
-
Copy full SHA for 2f91223 - Browse repository at this point
Copy the full SHA 2f91223View commit details -
Test example was much more easier to write with some kind of state management library.
Configuration menu - View commit details
-
Copy full SHA for b106b8b - Browse repository at this point
Copy the full SHA b106b8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a4ff66 - Browse repository at this point
Copy the full SHA 9a4ff66View commit details -
Configuration menu - View commit details
-
Copy full SHA for a30f4ee - Browse repository at this point
Copy the full SHA a30f4eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d84f64c - Browse repository at this point
Copy the full SHA d84f64cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d1fff5 - Browse repository at this point
Copy the full SHA 6d1fff5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a40aae1 - Browse repository at this point
Copy the full SHA a40aae1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9672ec1 - Browse repository at this point
Copy the full SHA 9672ec1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75fe630 - Browse repository at this point
Copy the full SHA 75fe630View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5248114 - Browse repository at this point
Copy the full SHA 5248114View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38b2fe8 - Browse repository at this point
Copy the full SHA 38b2fe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94e2686 - Browse repository at this point
Copy the full SHA 94e2686View commit details -
Change
sheetAllowedDetents
prop type toSheetDetentTypes | number[]
And handle this change in `NativeStackView`
Configuration menu - View commit details
-
Copy full SHA for 42080f0 - Browse repository at this point
Copy the full SHA 42080f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6db2b0a - Browse repository at this point
Copy the full SHA 6db2b0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 664852f - Browse repository at this point
Copy the full SHA 664852fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38851a9 - Browse repository at this point
Copy the full SHA 38851a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8512a04 - Browse repository at this point
Copy the full SHA 8512a04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33a192c - Browse repository at this point
Copy the full SHA 33a192cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc3db10 - Browse repository at this point
Copy the full SHA dc3db10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c35d5d - Browse repository at this point
Copy the full SHA 5c35d5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fba211f - Browse repository at this point
Copy the full SHA fba211fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e709618 - Browse repository at this point
Copy the full SHA e709618View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a29c55 - Browse repository at this point
Copy the full SHA 8a29c55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6393124 - Browse repository at this point
Copy the full SHA 6393124View commit details -
Configuration menu - View commit details
-
Copy full SHA for e297812 - Browse repository at this point
Copy the full SHA e297812View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96003ba - Browse repository at this point
Copy the full SHA 96003baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44946ca - Browse repository at this point
Copy the full SHA 44946caView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5d2c94 - Browse repository at this point
Copy the full SHA a5d2c94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33049fc - Browse repository at this point
Copy the full SHA 33049fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e8e6f0 - Browse repository at this point
Copy the full SHA 8e8e6f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22fddb7 - Browse repository at this point
Copy the full SHA 22fddb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f992f0 - Browse repository at this point
Copy the full SHA 6f992f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c877a53 - Browse repository at this point
Copy the full SHA c877a53View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0a7912 - Browse repository at this point
Copy the full SHA a0a7912View commit details -
fix(iOS): modal view flickering (#1870)
## Description Should be merged to #1852 or first rebased and then merged to main after #1852. Closes #1722 So the exact roots of the issue are unclear & obfuscated. It seems that it might be related to following (not 100% sure): 1. It looks like during animation `viewDidLayoutSubviews` is being called which in turn calls `setSize:forView:` on UIManager. This triggers Yoga layout underneath which sets view dimensions to the target values (end animation values) resulting in view clipping during the animation. There are two more important facts: a. its hard to determine whether its Yoga who sets invalid value or it gets invalid value from us (passed in `updateBounds` method after `viewDidLayoutSubviews` is triggered by system. b. when uimanager is not notified of bounds size change everything works fine I've considered various approaches: 1. Do not pass the value to UIManager when animation is ongoing. Presence of animation was detected by checking `animationKeys` property of view's layer. This still resulted in visual glitches. Moreover if I sent the final value after animation finish (via completion block) it resulted in content jumping (see [here](facebook/react-native#34834 (comment))). 2. Use `CADisplayLink` & report to UIManager bounds size from `presentationLayer` (that should be (almost) accurate value), but it still resulted in visual glitches (even when sliding down), both flickering and content jumping or just content had wrong top offset / padding. 3. Do not notify UIManager at all on bounds change. ## Changes I went with this approach for now. That is: I do not notify uimanager on bounds change when `stackPresentation == formSheet`. This is wild I know. I experimented a bit trying to find out what did it broke, but I did not find anything on my toy example (Test1649), however it is highly unlikely that such approach does not have negative impact, but I believe it is better that way, than having formsheets unusable due to this flickering. ## Test code and steps to reproduce Test1649 ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes
Configuration menu - View commit details
-
Copy full SHA for b4a81d9 - Browse repository at this point
Copy the full SHA b4a81d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd641ec - Browse repository at this point
Copy the full SHA dd641ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for c27ab79 - Browse repository at this point
Copy the full SHA c27ab79View commit details -
Configuration menu - View commit details
-
Copy full SHA for a68b907 - Browse repository at this point
Copy the full SHA a68b907View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3920f2a - Browse repository at this point
Copy the full SHA 3920f2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e27264 - Browse repository at this point
Copy the full SHA 8e27264View commit details -
Configuration menu - View commit details
-
Copy full SHA for a63d768 - Browse repository at this point
Copy the full SHA a63d768View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25a9f70 - Browse repository at this point
Copy the full SHA 25a9f70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09c1143 - Browse repository at this point
Copy the full SHA 09c1143View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c334a2 - Browse repository at this point
Copy the full SHA 0c334a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for aac2cee - Browse repository at this point
Copy the full SHA aac2ceeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f6e12f - Browse repository at this point
Copy the full SHA 5f6e12fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bbed13 - Browse repository at this point
Copy the full SHA 4bbed13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6653171 - Browse repository at this point
Copy the full SHA 6653171View commit details -
Configuration menu - View commit details
-
Copy full SHA for d08aba3 - Browse repository at this point
Copy the full SHA d08aba3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 413832b - Browse repository at this point
Copy the full SHA 413832bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15820e2 - Browse repository at this point
Copy the full SHA 15820e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed028ad - Browse repository at this point
Copy the full SHA ed028adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c8805b - Browse repository at this point
Copy the full SHA 1c8805bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1fa392 - Browse repository at this point
Copy the full SHA b1fa392View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ce92a7 - Browse repository at this point
Copy the full SHA 0ce92a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5530b16 - Browse repository at this point
Copy the full SHA 5530b16View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0f20fe - Browse repository at this point
Copy the full SHA b0f20feView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0b76be - Browse repository at this point
Copy the full SHA e0b76beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 768c2ca - Browse repository at this point
Copy the full SHA 768c2caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7aa835f - Browse repository at this point
Copy the full SHA 7aa835fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78510bd - Browse repository at this point
Copy the full SHA 78510bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d8ce7e - Browse repository at this point
Copy the full SHA 4d8ce7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e2c6c5 - Browse repository at this point
Copy the full SHA 0e2c6c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 406eed2 - Browse repository at this point
Copy the full SHA 406eed2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19704b1 - Browse repository at this point
Copy the full SHA 19704b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd75129 - Browse repository at this point
Copy the full SHA dd75129View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e8b5b4 - Browse repository at this point
Copy the full SHA 8e8b5b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 839b9d4 - Browse repository at this point
Copy the full SHA 839b9d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4808e49 - Browse repository at this point
Copy the full SHA 4808e49View commit details
Commits on Feb 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e509aa6 - Browse repository at this point
Copy the full SHA e509aa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d07156a - Browse repository at this point
Copy the full SHA d07156aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6eb4a3b - Browse repository at this point
Copy the full SHA 6eb4a3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for edb04f4 - Browse repository at this point
Copy the full SHA edb04f4View commit details
Commits on Feb 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 96a0abf - Browse repository at this point
Copy the full SHA 96a0abfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bfb629 - Browse repository at this point
Copy the full SHA 6bfb629View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d923e4 - Browse repository at this point
Copy the full SHA 2d923e4View commit details
Commits on Feb 22, 2024
-
There is still issue when keyboard is going down
Configuration menu - View commit details
-
Copy full SHA for 75e0af8 - Browse repository at this point
Copy the full SHA 75e0af8View commit details -
Configuration menu - View commit details
-
Copy full SHA for acc12ea - Browse repository at this point
Copy the full SHA acc12eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c99b184 - Browse repository at this point
Copy the full SHA c99b184View commit details
Commits on Feb 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 55776cd - Browse repository at this point
Copy the full SHA 55776cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6022759 - Browse repository at this point
Copy the full SHA 6022759View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00aac51 - Browse repository at this point
Copy the full SHA 00aac51View commit details
Commits on Feb 24, 2024
-
Add PoC of fitToContents for iOS (see commit details!)
I do need to figure out what to do with wrapping screen content in `AppContainer` in `NativeStackView`. Right now I just removed it, but it was necessary for those red/yellow box popups to work on debug configuration.
Configuration menu - View commit details
-
Copy full SHA for c3eb4a9 - Browse repository at this point
Copy the full SHA c3eb4a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7c262e - Browse repository at this point
Copy the full SHA b7c262eView commit details
Commits on Feb 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dfc95cd - Browse repository at this point
Copy the full SHA dfc95cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ce40cd - Browse repository at this point
Copy the full SHA 5ce40cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91cea41 - Browse repository at this point
Copy the full SHA 91cea41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05a5085 - Browse repository at this point
Copy the full SHA 05a5085View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f0da1e - Browse repository at this point
Copy the full SHA 2f0da1eView commit details
Commits on Feb 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 74dc5b0 - Browse repository at this point
Copy the full SHA 74dc5b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3744929 - Browse repository at this point
Copy the full SHA 3744929View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1533ec - Browse repository at this point
Copy the full SHA b1533ecView commit details
Commits on Feb 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d85cb17 - Browse repository at this point
Copy the full SHA d85cb17View commit details
Commits on Mar 1, 2024
-
Add sheetInitialDetentProp mock (see details) (Android & JS)
This is not functional yet, only the value is passed to native, logic is missing.
Configuration menu - View commit details
-
Copy full SHA for 4c6ecdc - Browse repository at this point
Copy the full SHA 4c6ecdcView commit details
Commits on Mar 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 692904f - Browse repository at this point
Copy the full SHA 692904fView commit details
Commits on Apr 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eb5986a - Browse repository at this point
Copy the full SHA eb5986aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4ebf84 - Browse repository at this point
Copy the full SHA e4ebf84View commit details -
Configuration menu - View commit details
-
Copy full SHA for e484e8a - Browse repository at this point
Copy the full SHA e484e8aView commit details
Commits on Apr 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eddcd8e - Browse repository at this point
Copy the full SHA eddcd8eView commit details
Commits on Apr 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 06a2167 - Browse repository at this point
Copy the full SHA 06a2167View commit details
Commits on Apr 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c4183aa - Browse repository at this point
Copy the full SHA c4183aaView commit details
Commits on May 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8fc1ecb - Browse repository at this point
Copy the full SHA 8fc1ecbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 127efbb - Browse repository at this point
Copy the full SHA 127efbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cad0c2 - Browse repository at this point
Copy the full SHA 4cad0c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03e0633 - Browse repository at this point
Copy the full SHA 03e0633View commit details -
Configuration menu - View commit details
-
Copy full SHA for f81d1b9 - Browse repository at this point
Copy the full SHA f81d1b9View commit details
Commits on May 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b286c48 - Browse repository at this point
Copy the full SHA b286c48View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8e25b9 - Browse repository at this point
Copy the full SHA b8e25b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b7fb41 - Browse repository at this point
Copy the full SHA 7b7fb41View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3aafbd - Browse repository at this point
Copy the full SHA c3aafbdView commit details -
Merge branch 'main' into @kkafar/custom-detents-pg-merge-2
Conflicts: FabricTestExample/yarn.lock TestsExample/ios/Podfile.lock TestsExample/yarn.lock android/build.gradle android/src/main/java/com/swmansion/rnscreens/Screen.kt android/src/main/java/com/swmansion/rnscreens/ScreenStack.kt android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt ios/RNSScreen.mm react-native.config.js src/components/Screen.tsx src/fabric/ScreenNativeComponent.ts yarn.lock
Configuration menu - View commit details
-
Copy full SHA for 03c056e - Browse repository at this point
Copy the full SHA 03c056eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6c880e - Browse repository at this point
Copy the full SHA e6c880eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad68762 - Browse repository at this point
Copy the full SHA ad68762View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dd9b50 - Browse repository at this point
Copy the full SHA 0dd9b50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85e509b - Browse repository at this point
Copy the full SHA 85e509bView commit details -
Configuration menu - View commit details
-
Copy full SHA for da15cae - Browse repository at this point
Copy the full SHA da15caeView commit details
Commits on May 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 48779d4 - Browse repository at this point
Copy the full SHA 48779d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6aae2ca - Browse repository at this point
Copy the full SHA 6aae2caView commit details -
Configuration menu - View commit details
-
Copy full SHA for b316f26 - Browse repository at this point
Copy the full SHA b316f26View commit details -
Configuration menu - View commit details
-
Copy full SHA for cca0279 - Browse repository at this point
Copy the full SHA cca0279View commit details
Commits on May 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c566288 - Browse repository at this point
Copy the full SHA c566288View commit details -
Configuration menu - View commit details
-
Copy full SHA for 626319b - Browse repository at this point
Copy the full SHA 626319bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40c1abd - Browse repository at this point
Copy the full SHA 40c1abdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28efb25 - Browse repository at this point
Copy the full SHA 28efb25View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4698d0 - Browse repository at this point
Copy the full SHA b4698d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcb97da - Browse repository at this point
Copy the full SHA dcb97daView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6ccf8d - Browse repository at this point
Copy the full SHA a6ccf8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 458af30 - Browse repository at this point
Copy the full SHA 458af30View commit details -
Configuration menu - View commit details
-
Copy full SHA for d056286 - Browse repository at this point
Copy the full SHA d056286View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f14195 - Browse repository at this point
Copy the full SHA 5f14195View commit details -
Configuration menu - View commit details
-
Copy full SHA for 809aee5 - Browse repository at this point
Copy the full SHA 809aee5View commit details
Commits on May 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ed74c9f - Browse repository at this point
Copy the full SHA ed74c9fView commit details
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ffefdfc - Browse repository at this point
Copy the full SHA ffefdfcView commit details
Commits on May 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9289f24 - Browse repository at this point
Copy the full SHA 9289f24View commit details -
Configuration menu - View commit details
-
Copy full SHA for c03decb - Browse repository at this point
Copy the full SHA c03decbView commit details
Commits on May 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e8b6824 - Browse repository at this point
Copy the full SHA e8b6824View commit details
Commits on May 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 99f95a6 - Browse repository at this point
Copy the full SHA 99f95a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50adfc4 - Browse repository at this point
Copy the full SHA 50adfc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 255e4c5 - Browse repository at this point
Copy the full SHA 255e4c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42e86bb - Browse repository at this point
Copy the full SHA 42e86bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14d960d - Browse repository at this point
Copy the full SHA 14d960dView commit details
Commits on May 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9d2bcda - Browse repository at this point
Copy the full SHA 9d2bcdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04803c5 - Browse repository at this point
Copy the full SHA 04803c5View commit details
Commits on May 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e77d467 - Browse repository at this point
Copy the full SHA e77d467View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82bc8e9 - Browse repository at this point
Copy the full SHA 82bc8e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ff2f6f - Browse repository at this point
Copy the full SHA 7ff2f6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97ee80a - Browse repository at this point
Copy the full SHA 97ee80aView commit details
Commits on Jun 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cf8c18a - Browse repository at this point
Copy the full SHA cf8c18aView commit details
Commits on Jun 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f1e9ad4 - Browse repository at this point
Copy the full SHA f1e9ad4View commit details
Commits on Jun 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5f936b6 - Browse repository at this point
Copy the full SHA 5f936b6View commit details -
fix: bump gradle wrapper version to 7.5.1 & not use app node_modules …
…when running tasks from repo (#2186) ## Description Basically tasks run from react-native-screens repo (such as linting & formating) would fail due to outdated gradle wrapper version (and the fact that we re using newer JDK now). There was a second issue: when running tasks from react-native-screens project as gradle's `rootProject` and simultaneously having `react-native` repo side-by-side to `react-native-screens` repo on disk - our current react native directory resolution algorithm would have found it and attempt to use to retrieve RN version, but: 1. the gradle.properties file is not there, 2. retrieved version could be out of sync with what's in project. ## Changes * Bumped gradle wrapper version to 7.5.1 (we were still on major 6). * Adjusted the react native directory algorithm just a bit, so that when running in context of screens repo we skip one code path. There was also possibility to "reorder the ifs" in `resolveReactNativeDir` function, however this could possible cause issues in user projects - we want first to look for app's node modules and later for project node modules. ## Test code and steps to reproduce `yarn lint-android`, `yarn format-android`, etc. should now work just fine when you re on JDK 17+ & have `react-native` repo side by side to `react-native-screens`. ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
Configuration menu - View commit details
-
Copy full SHA for 4825e2c - Browse repository at this point
Copy the full SHA 4825e2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7772707 - Browse repository at this point
Copy the full SHA 7772707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 384f3e0 - Browse repository at this point
Copy the full SHA 384f3e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaee08d - Browse repository at this point
Copy the full SHA aaee08dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c474285 - Browse repository at this point
Copy the full SHA c474285View commit details -
Configuration menu - View commit details
-
Copy full SHA for cebb527 - Browse repository at this point
Copy the full SHA cebb527View commit details -
Configuration menu - View commit details
-
Copy full SHA for e53f30b - Browse repository at this point
Copy the full SHA e53f30bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24083ee - Browse repository at this point
Copy the full SHA 24083eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9157e31 - Browse repository at this point
Copy the full SHA 9157e31View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbbbc6b - Browse repository at this point
Copy the full SHA fbbbc6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2eb3cf5 - Browse repository at this point
Copy the full SHA 2eb3cf5View commit details
Commits on Jun 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f35131c - Browse repository at this point
Copy the full SHA f35131cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c5a1d5 - Browse repository at this point
Copy the full SHA 7c5a1d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc8b06c - Browse repository at this point
Copy the full SHA cc8b06cView commit details
Commits on Jun 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6d919cd - Browse repository at this point
Copy the full SHA 6d919cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7c7a86 - Browse repository at this point
Copy the full SHA f7c7a86View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc832d3 - Browse repository at this point
Copy the full SHA dc832d3View commit details
Commits on Jun 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e58c0b3 - Browse repository at this point
Copy the full SHA e58c0b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c71061c - Browse repository at this point
Copy the full SHA c71061cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ad9968 - Browse repository at this point
Copy the full SHA 8ad9968View commit details -
Configuration menu - View commit details
-
Copy full SHA for ede0b5b - Browse repository at this point
Copy the full SHA ede0b5bView commit details
Commits on Jun 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3cdecb7 - Browse repository at this point
Copy the full SHA 3cdecb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 495b3eb - Browse repository at this point
Copy the full SHA 495b3ebView commit details -
Remove keyboard & footer related code on iOS (RNSScreen)
I'm going to implement footer support on iOS with separate PR (if at all)
Configuration menu - View commit details
-
Copy full SHA for 6b541b4 - Browse repository at this point
Copy the full SHA 6b541b4View commit details
Commits on Jun 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c8ee412 - Browse repository at this point
Copy the full SHA c8ee412View commit details
Commits on Jun 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 19e863f - Browse repository at this point
Copy the full SHA 19e863fView commit details
Commits on Jul 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 16b4145 - Browse repository at this point
Copy the full SHA 16b4145View commit details
Commits on Jul 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9bb8322 - Browse repository at this point
Copy the full SHA 9bb8322View commit details
Commits on Jul 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e7d6e3d - Browse repository at this point
Copy the full SHA e7d6e3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd01f5b - Browse repository at this point
Copy the full SHA fd01f5bView commit details
Commits on Jul 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 79a2484 - Browse repository at this point
Copy the full SHA 79a2484View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5964f4d - Browse repository at this point
Copy the full SHA 5964f4dView commit details
Commits on Jul 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 600f818 - Browse repository at this point
Copy the full SHA 600f818View commit details -
Configuration menu - View commit details
-
Copy full SHA for a74598a - Browse repository at this point
Copy the full SHA a74598aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f8f411 - Browse repository at this point
Copy the full SHA 1f8f411View commit details -
Configuration menu - View commit details
-
Copy full SHA for c301f2b - Browse repository at this point
Copy the full SHA c301f2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3af9813 - Browse repository at this point
Copy the full SHA 3af9813View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1965b6 - Browse repository at this point
Copy the full SHA b1965b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9fbce7 - Browse repository at this point
Copy the full SHA d9fbce7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44be1b5 - Browse repository at this point
Copy the full SHA 44be1b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a64f41 - Browse repository at this point
Copy the full SHA 1a64f41View commit details
Commits on Jul 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fe036cd - Browse repository at this point
Copy the full SHA fe036cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f99c80 - Browse repository at this point
Copy the full SHA 7f99c80View commit details
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 15e096d - Browse repository at this point
Copy the full SHA 15e096dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b3053f - Browse repository at this point
Copy the full SHA 0b3053fView commit details
Commits on Aug 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e2c997a - Browse repository at this point
Copy the full SHA e2c997aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ddff79e - Browse repository at this point
Copy the full SHA ddff79eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c46bbbe - Browse repository at this point
Copy the full SHA c46bbbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38655c2 - Browse repository at this point
Copy the full SHA 38655c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8c27ec - Browse repository at this point
Copy the full SHA a8c27ecView commit details
Commits on Aug 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 62dc767 - Browse repository at this point
Copy the full SHA 62dc767View commit details -
Configuration menu - View commit details
-
Copy full SHA for adc0d61 - Browse repository at this point
Copy the full SHA adc0d61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f752db - Browse repository at this point
Copy the full SHA 3f752dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74ac52e - Browse repository at this point
Copy the full SHA 74ac52eView commit details