Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: iOS custom detents & Android form sheets #2045

Merged
merged 319 commits into from
Aug 10, 2024
Merged
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jan 7, 2024

  1. Configuration menu
    Copy the full SHA
    49b5ad6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    700d46e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7b4ed40 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    612ada8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    86307aa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    00d50b2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c442b25 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Remove unused function

    kkafar committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    426bee8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c3abf7c View commit details
    Browse the repository at this point in the history
  3. Add react-versioned files

    kkafar committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    20a7ae6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1a0653d View commit details
    Browse the repository at this point in the history
  5. Revert "Add react-versioned files"

    This reverts commit 20a7ae6.
    kkafar committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    6bda77c View commit details
    Browse the repository at this point in the history
  6. Revert "Remove RNSModalRootView.kt from main source set"

    This reverts commit 1a0653d.
    kkafar committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    2fe8144 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    57f0b43 View commit details
    Browse the repository at this point in the history
  8. Fix 3-level detet

    kkafar committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f8e9baf View commit details
    Browse the repository at this point in the history
  9. Update TE

    kkafar committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    cadde6a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    dafca03 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4dea550 View commit details
    Browse the repository at this point in the history
  12. Small renaming

    kkafar committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4f47012 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Configuration menu
    Copy the full SHA
    f604827 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    087a938 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d940324 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1323f1a View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Configuration menu
    Copy the full SHA
    52e5839 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Restore content diplay

    kkafar committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    7cab9c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Configuration menu
    Copy the full SHA
    1ca4e3d View commit details
    Browse the repository at this point in the history
  2. Improve sheet animation

    kkafar committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    49caf0a View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Configuration menu
    Copy the full SHA
    ab835b8 View commit details
    Browse the repository at this point in the history
  2. Update example in TE

    kkafar committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    77b9670 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f8b3946 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4479c1a View commit details
    Browse the repository at this point in the history
  5. Update yarn.lock

    kkafar committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    72b2631 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1acbdc6 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Configuration menu
    Copy the full SHA
    a11db31 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Update example

    kkafar committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    bbfb20f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c7cddc View commit details
    Browse the repository at this point in the history
  3. Add stub for ScreenFooter

    kkafar committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    a214f19 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Add first stub code for footer

    kkafar committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    9d86a34 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Fix type error

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0550367 View commit details
    Browse the repository at this point in the history
  2. Add PoC

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0753533 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    97c29ce View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ed8874e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9d3bdd5 View commit details
    Browse the repository at this point in the history
  6. Remove debug logging

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b6939fc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    88d10d8 View commit details
    Browse the repository at this point in the history
  8. Cleanup native code a bit

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    3763cf3 View commit details
    Browse the repository at this point in the history
  9. Rename updatePresentationStyle to updateFormSheetPresentationStyle

    So that the method's name better describes its purpose
    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    2f91223 View commit details
    Browse the repository at this point in the history
  10. Add dev dependency on jotai

    Test example was much more easier to write with some kind of state
    management library.
    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b106b8b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9a4ff66 View commit details
    Browse the repository at this point in the history
  12. Indentation

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a30f4ee View commit details
    Browse the repository at this point in the history
  13. Update example in FTE

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d84f64c View commit details
    Browse the repository at this point in the history
  14. Start implementing Fabric

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6d1fff5 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    a40aae1 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9672ec1 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    75fe630 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    5248114 View commit details
    Browse the repository at this point in the history
  19. Filter numbers

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    38b2fe8 View commit details
    Browse the repository at this point in the history
  20. Stash changes

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    94e2686 View commit details
    Browse the repository at this point in the history
  21. Change sheetAllowedDetents prop type to SheetDetentTypes | number[]

    And handle this change in `NativeStackView`
    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    42080f0 View commit details
    Browse the repository at this point in the history
  22. Refactor native code

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6db2b0a View commit details
    Browse the repository at this point in the history
  23. Update example in TE

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    664852f View commit details
    Browse the repository at this point in the history
  24. Cleanup logic in v5 impl a bit

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    38851a9 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    8512a04 View commit details
    Browse the repository at this point in the history
  26. custom largest undimmed detent

    Hate this naming
    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    33a192c View commit details
    Browse the repository at this point in the history
  27. Improve native logic

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    dc3db10 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    5c35d5d View commit details
    Browse the repository at this point in the history
  29. Update example in TE

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    fba211f View commit details
    Browse the repository at this point in the history
  30. Add docs

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    e709618 View commit details
    Browse the repository at this point in the history
  31. Missing newline

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8a29c55 View commit details
    Browse the repository at this point in the history
  32. Adjust Fabric implementations

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6393124 View commit details
    Browse the repository at this point in the history
  33. Add missing docs

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    e297812 View commit details
    Browse the repository at this point in the history
  34. Cleanup tests

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    96003ba View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    44946ca View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    a5d2c94 View commit details
    Browse the repository at this point in the history
  37. Stubs for Android

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    33049fc View commit details
    Browse the repository at this point in the history
  38. Spelling 1

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8e8e6f0 View commit details
    Browse the repository at this point in the history
  39. Spelling 2

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    22fddb7 View commit details
    Browse the repository at this point in the history
  40. Improve example logic a bit

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6f992f0 View commit details
    Browse the repository at this point in the history
  41. Remove RNS Array utility

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    c877a53 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    a0a7912 View commit details
    Browse the repository at this point in the history
  43. fix(iOS): modal view flickering (#1870)

    ## Description
    
    Should be merged to #1852 or first rebased and then merged to main after
    #1852.
    
    Closes #1722 
    
    So the exact roots of the issue are unclear & obfuscated. It seems that
    it might be related to following (not 100% sure):
    
    1. It looks like during animation `viewDidLayoutSubviews` is being
    called which in turn calls `setSize:forView:` on UIManager. This
    triggers Yoga layout underneath which sets view dimensions to the target
    values (end animation values) resulting in view clipping during the
    animation. There are two more important facts:
    
    a. its hard to determine whether its Yoga who sets invalid value or it
    gets invalid value from us (passed in `updateBounds` method after
    `viewDidLayoutSubviews` is triggered by system.
    
    b. when uimanager is not notified of bounds size change everything works
    fine
    
    I've considered various approaches:
    
    1. Do not pass the value to UIManager when animation is ongoing.
    Presence of animation was detected by checking `animationKeys` property
    of view's layer. This still resulted in visual glitches. Moreover if I
    sent the final value after animation finish (via completion block) it
    resulted in content jumping (see
    [here](facebook/react-native#34834 (comment))).
    2. Use `CADisplayLink` & report to UIManager bounds size from
    `presentationLayer` (that should be (almost) accurate value), but it
    still resulted in visual glitches (even when sliding down), both
    flickering and content jumping or just content had wrong top offset /
    padding.
    3. Do not notify UIManager at all on bounds change. 
    
    
    ## Changes
    
    I went with this approach for now. That is: I do not notify uimanager on
    bounds change when `stackPresentation == formSheet`. This is wild I
    know. I experimented a bit trying to find out what did it broke, but I
    did not find anything on my toy example (Test1649), however it is highly
    unlikely that such approach does not have negative impact, but I believe
    it is better that way, than having formsheets unusable due to this
    flickering.
    
    
    ## Test code and steps to reproduce
    
    Test1649
    
    ## Checklist
    
    - [x] Included code example that can be used to test this change
    - [x] Ensured that CI passes
    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b4a81d9 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    dd641ec View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    c27ab79 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    a68b907 View commit details
    Browse the repository at this point in the history
  47. Start cleaning up

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    3920f2a View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    8e27264 View commit details
    Browse the repository at this point in the history
  49. Update jotai

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a63d768 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    25a9f70 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    09c1143 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    0c334a2 View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    aac2cee View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    5f6e12f View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    4bbed13 View commit details
    Browse the repository at this point in the history
  56. REVERT: Stash debug setup

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6653171 View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    d08aba3 View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    413832b View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    15820e2 View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    ed028ad View commit details
    Browse the repository at this point in the history
  61. Update example in TE

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    1c8805b View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    b1fa392 View commit details
    Browse the repository at this point in the history
  63. Patch for scrollview

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0ce92a7 View commit details
    Browse the repository at this point in the history
  64. Cleanup 1

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    5530b16 View commit details
    Browse the repository at this point in the history
  65. Cleanup 2

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b0f20fe View commit details
    Browse the repository at this point in the history
  66. Cleanup 3

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    e0b76be View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    768c2ca View commit details
    Browse the repository at this point in the history
  68. Remove custom shadow view code

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7aa835f View commit details
    Browse the repository at this point in the history
  69. Configuration menu
    Copy the full SHA
    78510bd View commit details
    Browse the repository at this point in the history
  70. Update TE

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    4d8ce7e View commit details
    Browse the repository at this point in the history
  71. Remove merge artifacts v1

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0e2c6c5 View commit details
    Browse the repository at this point in the history
  72. TOREVERT: podfile lock

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    406eed2 View commit details
    Browse the repository at this point in the history
  73. Cleanup example a bit

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    19704b1 View commit details
    Browse the repository at this point in the history
  74. TOREVERT: yarn lock

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    dd75129 View commit details
    Browse the repository at this point in the history
  75. Rebase artifacts

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8e8b5b4 View commit details
    Browse the repository at this point in the history
  76. TOREVERT: podfile lock

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    839b9d4 View commit details
    Browse the repository at this point in the history
  77. prettier

    kkafar committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    4808e49 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Configuration menu
    Copy the full SHA
    e509aa6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d07156a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6eb4a3b View commit details
    Browse the repository at this point in the history
  4. Small fixes in example

    kkafar committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    edb04f4 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Configuration menu
    Copy the full SHA
    96a0abf View commit details
    Browse the repository at this point in the history
  2. Restore footer visibility

    kkafar committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    6bfb629 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2d923e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Make footer follow keyboard

    There is still issue when keyboard is going down
    kkafar committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    75e0af8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    acc12ea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c99b184 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Configuration menu
    Copy the full SHA
    55776cd View commit details
    Browse the repository at this point in the history
  2. Update example

    kkafar committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    6022759 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00aac51 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Add PoC of fitToContents for iOS (see commit details!)

    I do need to figure out what to do with wrapping screen content in
    `AppContainer` in `NativeStackView`. Right now I just removed it,
    but it was necessary for those red/yellow box popups to work on debug
    configuration.
    kkafar committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    c3eb4a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7c262e View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Configuration menu
    Copy the full SHA
    dfc95cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ce40cd View commit details
    Browse the repository at this point in the history
  3. Eslint

    kkafar committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    91cea41 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    05a5085 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2f0da1e View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    74dc5b0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3744929 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b1533ec View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Configuration menu
    Copy the full SHA
    d85cb17 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Add sheetInitialDetentProp mock (see details) (Android & JS)

    This is not functional yet, only the value is passed to native, logic is
    missing.
    kkafar committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    4c6ecdc View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Configuration menu
    Copy the full SHA
    692904f View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    eb5986a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4ebf84 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e484e8a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Configuration menu
    Copy the full SHA
    eddcd8e View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Debugging setup 2

    kkafar committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    06a2167 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Configuration menu
    Copy the full SHA
    c4183aa View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Push stashed changes

    kkafar committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8fc1ecb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    127efbb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4cad0c2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    03e0633 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f81d1b9 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Configuration menu
    Copy the full SHA
    b286c48 View commit details
    Browse the repository at this point in the history
  2. Update example

    kkafar committed May 6, 2024
    Configuration menu
    Copy the full SHA
    b8e25b9 View commit details
    Browse the repository at this point in the history
  3. Improve keyboard handling

    kkafar committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7b7fb41 View commit details
    Browse the repository at this point in the history
  4. Update example

    kkafar committed May 6, 2024
    Configuration menu
    Copy the full SHA
    c3aafbd View commit details
    Browse the repository at this point in the history
  5. Merge branch 'main' into @kkafar/custom-detents-pg-merge-2

    Conflicts:
    	FabricTestExample/yarn.lock
    	TestsExample/ios/Podfile.lock
    	TestsExample/yarn.lock
    	android/build.gradle
    	android/src/main/java/com/swmansion/rnscreens/Screen.kt
    	android/src/main/java/com/swmansion/rnscreens/ScreenStack.kt
    	android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt
    	ios/RNSScreen.mm
    	react-native.config.js
    	src/components/Screen.tsx
    	src/fabric/ScreenNativeComponent.ts
    	yarn.lock
    kkafar committed May 6, 2024
    Configuration menu
    Copy the full SHA
    03c056e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e6c880e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ad68762 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0dd9b50 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    85e509b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    da15cae View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    48779d4 View commit details
    Browse the repository at this point in the history
  2. Comments in ScreenFooter

    kkafar committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6aae2ca View commit details
    Browse the repository at this point in the history
  3. Cleanup Screen a lot

    kkafar committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b316f26 View commit details
    Browse the repository at this point in the history
  4. Next round of cleanup

    kkafar committed May 7, 2024
    Configuration menu
    Copy the full SHA
    cca0279 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Restore modal code & cleanup

    kkafar committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c566288 View commit details
    Browse the repository at this point in the history
  2. Unify examples

    kkafar committed May 8, 2024
    Configuration menu
    Copy the full SHA
    626319b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    40c1abd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    28efb25 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b4698d0 View commit details
    Browse the repository at this point in the history
  6. Unify examples

    kkafar committed May 8, 2024
    Configuration menu
    Copy the full SHA
    dcb97da View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a6ccf8d View commit details
    Browse the repository at this point in the history
  8. Fix conversions on Fabric iOS

    kkafar committed May 8, 2024
    Configuration menu
    Copy the full SHA
    458af30 View commit details
    Browse the repository at this point in the history
  9. Fix event emitting on paper

    kkafar committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d056286 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5f14195 View commit details
    Browse the repository at this point in the history
  11. Update TE

    kkafar committed May 8, 2024
    Configuration menu
    Copy the full SHA
    809aee5 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Attempt to fix iOS compilation

    kkafar committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ed74c9f View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Configuration menu
    Copy the full SHA
    ffefdfc View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Configuration menu
    Copy the full SHA
    9289f24 View commit details
    Browse the repository at this point in the history
  2. Add missing import

    kkafar committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c03decb View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Configuration menu
    Copy the full SHA
    e8b6824 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    99f95a6 View commit details
    Browse the repository at this point in the history
  2. Update example

    kkafar committed May 22, 2024
    Configuration menu
    Copy the full SHA
    50adfc4 View commit details
    Browse the repository at this point in the history
  3. Update android layout

    kkafar committed May 22, 2024
    Configuration menu
    Copy the full SHA
    255e4c5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    42e86bb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    14d960d View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Configuration menu
    Copy the full SHA
    9d2bcda View commit details
    Browse the repository at this point in the history
  2. Stash debugging setup

    kkafar committed May 27, 2024
    Configuration menu
    Copy the full SHA
    04803c5 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Configuration menu
    Copy the full SHA
    e77d467 View commit details
    Browse the repository at this point in the history
  2. prettier in src/native-stack

    kkafar committed May 30, 2024
    Configuration menu
    Copy the full SHA
    82bc8e9 View commit details
    Browse the repository at this point in the history
  3. Prettier in src/types.tsx

    kkafar committed May 30, 2024
    Configuration menu
    Copy the full SHA
    7ff2f6f View commit details
    Browse the repository at this point in the history
  4. Update examples

    kkafar committed May 30, 2024
    Configuration menu
    Copy the full SHA
    97ee80a View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Remove unused implementation

    kkafar committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    cf8c18a View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Configuration menu
    Copy the full SHA
    f1e9ad4 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Configuration menu
    Copy the full SHA
    5f936b6 View commit details
    Browse the repository at this point in the history
  2. fix: bump gradle wrapper version to 7.5.1 & not use app node_modules …

    …when running tasks from repo (#2186)
    
    ## Description
    
    Basically tasks run from react-native-screens repo (such as linting &
    formating) would fail due to outdated gradle wrapper version (and the
    fact that we re using newer JDK now).
    
    There was a second issue: when running tasks from react-native-screens
    project as gradle's `rootProject` and simultaneously having
    `react-native` repo side-by-side to `react-native-screens`
    repo on disk - our current react native directory resolution algorithm
    would have found it and attempt to use to retrieve RN version, but:
    
    1. the gradle.properties file is not there,
    2. retrieved version could be out of sync with what's in project.
    
    
    ## Changes
    
    * Bumped gradle wrapper version to 7.5.1 (we were still on major 6).
    * Adjusted the react native directory algorithm just a bit, so that when
    running in context of screens repo we skip one code path.
    
    There was also possibility to "reorder the ifs" in
    `resolveReactNativeDir` function, however this could possible cause
    issues in user projects - we want first to look for app's node modules
    and later for project node modules.
    
    
    ## Test code and steps to reproduce
    
    `yarn lint-android`, `yarn format-android`, etc. should now work just
    fine when you re on JDK 17+ & have `react-native` repo side by side to
    `react-native-screens`.
    
    ## Checklist
    
    - [ ] Included code example that can be used to test this change
    - [ ] Updated TS types
    - [ ] Updated documentation: <!-- For adding new props to native-stack
    -->
    - [ ]
    https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md
    - [ ]
    https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md
    - [ ]
    https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx
    - [ ]
    https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx
    - [ ] Ensured that CI passes
    kkafar committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    4825e2c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7772707 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    384f3e0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    aaee08d View commit details
    Browse the repository at this point in the history
  6. Fix missing node_modules path

    kkafar committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    c474285 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cebb527 View commit details
    Browse the repository at this point in the history
  8. Revert "Fix missing node_modules path"

    This reverts commit c474285.
    kkafar committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e53f30b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    24083ee View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9157e31 View commit details
    Browse the repository at this point in the history
  11. Remove unused import

    kkafar committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    fbbbc6b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2eb3cf5 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Configuration menu
    Copy the full SHA
    f35131c View commit details
    Browse the repository at this point in the history
  2. Reorganise Test1649

    kkafar committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7c5a1d5 View commit details
    Browse the repository at this point in the history
  3. Example cleanup - part 1

    kkafar committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    cc8b06c View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Example cleanup - part 2

    kkafar committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    6d919cd View commit details
    Browse the repository at this point in the history
  2. Example cleanup - part 3

    kkafar committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f7c7a86 View commit details
    Browse the repository at this point in the history
  3. Attempt to use v7 API

    kkafar committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    dc832d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Configuration menu
    Copy the full SHA
    e58c0b3 View commit details
    Browse the repository at this point in the history
  2. Fixup route names in example

    kkafar committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c71061c View commit details
    Browse the repository at this point in the history
  3. Add SheetUtils + cleanup

    kkafar committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    8ad9968 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ede0b5b View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Configuration menu
    Copy the full SHA
    3cdecb7 View commit details
    Browse the repository at this point in the history
  2. Remove some comments on iOS

    kkafar committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    495b3eb View commit details
    Browse the repository at this point in the history
  3. Remove keyboard & footer related code on iOS (RNSScreen)

    I'm going to implement footer support on iOS with separate PR (if at all)
    kkafar committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6b541b4 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Configuration menu
    Copy the full SHA
    c8ee412 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Configuration menu
    Copy the full SHA
    19e863f View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Configuration menu
    Copy the full SHA
    16b4145 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Configuration menu
    Copy the full SHA
    9bb8322 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    e7d6e3d View commit details
    Browse the repository at this point in the history
  2. Remove merge artifact

    kkafar committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fd01f5b View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    79a2484 View commit details
    Browse the repository at this point in the history
  2. Make Fabic build on iOS

    kkafar committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    5964f4d View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    600f818 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a74598a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1f8f411 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c301f2b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3af9813 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b1965b6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d9fbce7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    44be1b5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1a64f41 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Cleanup iOS code

    kkafar committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    fe036cd View commit details
    Browse the repository at this point in the history
  2. Update example

    kkafar committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    7f99c80 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    15e096d View commit details
    Browse the repository at this point in the history
  2. Update isTransparent method

    kkafar committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0b3053f View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Review updates 1

    kkafar committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e2c997a View commit details
    Browse the repository at this point in the history
  2. Review updates 2

    kkafar committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    ddff79e View commit details
    Browse the repository at this point in the history
  3. Review updates 3

    kkafar committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c46bbbe View commit details
    Browse the repository at this point in the history
  4. Patch for tvOS & visionOS

    kkafar committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    38655c2 View commit details
    Browse the repository at this point in the history
  5. Self review changes - Android

    kkafar committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    a8c27ec View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Configuration menu
    Copy the full SHA
    62dc767 View commit details
    Browse the repository at this point in the history
  2. Update native stack v5 docs

    kkafar committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    adc0d61 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3f752db View commit details
    Browse the repository at this point in the history
  4. patch for linter

    kkafar committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    74ac52e View commit details
    Browse the repository at this point in the history