Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): stabilize Android E2E tests #2062

Merged
merged 9 commits into from
Mar 12, 2024
Merged

fix(CI): stabilize Android E2E tests #2062

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f31b41e
fix: stable e2e tests (Android)
kirillzyusko Mar 11, 2024
d4f331c
fix: added logger, use modern runner
kirillzyusko Mar 11, 2024
1a8a16e
fix: come back to macos 12
kirillzyusko Mar 11, 2024
f60f49a
fix: suppress system UI is not responding
kirillzyusko Mar 11, 2024
5da19f1
fix: suppress system UI is not responding in the same block with emul…
kirillzyusko Mar 11, 2024
f046e8a
fix: try to use atd image
kirillzyusko Mar 11, 2024
4735981
fix: remove suppressing code
kirillzyusko Mar 11, 2024
02de236
chore: cleanup
kirillzyusko Mar 11, 2024
0addb6d
chore: changes according to review
kirillzyusko Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/android-e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
with:
working-directory: ${{ env.WORKING_DIRECTORY }}
api-level: 31
target: default
target: aosp_atd
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this change does the trick 🤔

Actually you have "System UI isn't responding" popup instead of ANR (Application non responsive). So it's a different story, and from what observed in my experience "System UI isn't responding" happens if runner is weak. I've tried:

  • to use macos-14 runner (but in this case the emulator doesn't start at all)
  • to manually suppress this popup (doesn't work and popup is still present)
  • to switch to ATD image (Automated Test Device) - and it seems like it really helped

However I still think that keeping test butler can help in the future to prevent undesired ANR and make e2e tests more reliable 👀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, running android emulators on macos-14 is tough - there are some issues with running it (I know about one).
I think we can stay on aosp_atd and leave the test butler! I really appreciate your time spent on this! 🙏

Let me run a couple more of Android E2E actions and see if CI will work for sure 👍

profile: pixel_2
ram-size: '4096M'
disk-size: '10G'
Expand Down
2 changes: 2 additions & 0 deletions Example/.detoxrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,14 @@ module.exports = {
device: {
adbName: 'e2e_emulator',
},
utilBinaryPaths: ['e2e/apks/test-butler-app-2.2.1.apk'],
},
emulator: {
type: 'android.emulator',
device: {
avdName: 'e2e_emulator',
},
utilBinaryPaths: ['e2e/apks/test-butler-app-2.2.1.apk'],
},
},
configurations: {
Expand Down
Binary file added Example/e2e/apks/test-butler-app-2.2.1.apk
View file
Open in desktop
kirillzyusko marked this conversation as resolved.
Show resolved Hide resolved
Binary file not shown.
Loading