Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issues with presenting owned modals from foreign ones #2113

Merged
merged 4 commits into from
Apr 27, 2024
Merged

fix: issues with presenting owned modals from foreign ones #2113

merged 4 commits into from
Apr 27, 2024

Commits on Apr 26, 2024

  1. Add check for whether the first modal to be dismissed is foreign 

    In such case I've decided to trigger it's dismissal. This is IMO best
behaviour as this patches repored issue & it seems to me that this is
common use pattern.
    @kkafar
    kkafar committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0023f56 View commit details
    Browse the repository at this point in the history

  2. Add issue reproduction

    @kkafar
    kkafar committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e6b1174 View commit details
    Browse the repository at this point in the history

  3. Remove leftover comment

    @kkafar
    kkafar committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9e6f2f9 View commit details
    Browse the repository at this point in the history

  4. Casing

    @kkafar
    kkafar committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0e1b5e6 View commit details
    Browse the repository at this point in the history