chore: Prevent setting RTL mode in test examples #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboba
changed the title
maciekstosio
approved these changes
May 13, 2024
This was referenced Jul 17, 2024
This was referenced Jul 25, 2024
This was referenced Aug 20, 2024
This was referenced Aug 23, 2024
This was referenced Aug 30, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description This PR is a follow-up to software-mansion#2084 that fixes setting incorrect RTL mode in our example apps. The reason why it is being forced is that `I18nManager.forceRTL(true)` is being called from the global scope, which causes to force RTL, even if we're only importing the component **from file**. ## Changes - Moved `I18nManager.forceRTL(true);` to inner scope of App components. ## Test code and steps to reproduce Just run TestsExample & FabricTestExample ¯\_(ツ)_/¯ ## Checklist - [X] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up to #2084 that fixes setting incorrect RTL mode in our example apps.
The reason why it is being forced is that
I18nManager.forceRTL(true)is being called from the global scope, which causes to force RTL, even if we're only importing the component from file.Changes
I18nManager.forceRTL(true);to inner scope of App components.Test code and steps to reproduce
Just run TestsExample & FabricTestExample ¯_(ツ)_/¯
Checklist