Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when building paper after fabric #2142

Merged

Conversation

maciekstosio
Copy link
Contributor

@maciekstosio maciekstosio commented May 17, 2024

Description

Currently when you build Fabric app and then Paper app Android Studio has errors about duplicated classes. This should resolve that issue.

Test:
Packed with npm pack and tested on new expo app. Seems that everything is fine.

@maciekstosio maciekstosio changed the title Fix error when building paper after fabric fix: error when building paper after fabric May 17, 2024
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we are good here.

Before merging I would recommend creating fresh RN application, installing @react-navigation/native-stack, react-native-safe-area-context & our library from sourcecode & build Paper Android.
I'm wary here after recent release issues.

@maciekstosio
Copy link
Contributor Author

Yeah I think we are good here.

Before merging I would recommend creating fresh RN application, installing @react-navigation/native-stack, react-native-safe-area-context & our library from sourcecode & build Paper Android. I'm wary here after recent release issues.

Yeah, I packed the lib w npm pack and linked it to new expo app with all of those you mentioned. Everything seems to be working.

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we are good to go

@maciekstosio maciekstosio merged commit c3edd8a into main May 20, 2024
4 checks passed
@maciekstosio maciekstosio deleted the @maciekstosio/fix-errors-when-building-paper-after-fabric branch May 20, 2024 11:51
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
## Description

Currently when you build Fabric app and then Paper app Android Studio
has errors about duplicated classes. This should resolve that issue.

**Test:**
Packed with `npm pack` and tested on new expo app. Seems that everything
is fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants