fix(iOS): white flash on tab change when using native stack #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboba
requested changes
Jun 17, 2024
kkafar
reviewed
Jun 18, 2024
alduzy
force-pushed
the
@alduzy/white-flash-on-tab-change-fix
branch
from
26df1fa
to
2ba71d0
Compare
kkafar
approved these changes
Jul 8, 2024
Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
kkafar
approved these changes
Jul 8, 2024
|
Tested it using the provided |
|
Let me do a quick final check on examples if this works and I guess we can proceed with this one! |
|
Why are we need to test scenario from |
|
Alright, I understand 👍 |
|
Did you test on all supported |
|
I've just tested the change on iOS 15.5 and cannot spot any issues there 👍 |
tboba
reviewed
Jul 8, 2024
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…-mansion#2188) ## Description This PR gets rid of undesired white flashes during `maybeAddToParentAndUpdateContainer`. The white flash was present on paper architecture when `unmountOnBlur` option was set to true on parent bottomStackNavigator (see repro). The affected logic was previously introduced or changed by following PRs: - software-mansion#600 - software-mansion#613 - software-mansion#643 The removed `_hasLayout` was initially added by software-mansion#600 in order to resolve an issue: software-mansion#432. However the logic was later changed by software-mansion#613 in order to fix another issue and the added `_hasLayout` may not fix anything eventually, as stated by [this comment](software-mansion#432 (comment)). Fixes software-mansion#1645. ## Changes - removed `_hasLayout` variable - added repros ## Screenshots / GIFs ### Before https://github.com/software-mansion/react-native-screens/assets/91994767/226a32d7-728b-48dd-b21a-6a1e4195add2 ### After https://github.com/software-mansion/react-native-screens/assets/91994767/32febcf1-d159-4a9d-ae3a-373042732a6d ## Test code and steps to reproduce - added `Test1645.js` repro to test examples - added `Test432.tsx` repro to test examples ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes --------- Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gets rid of undesired white flashes during
maybeAddToParentAndUpdateContainer. The white flash was present on paper architecture whenunmountOnBluroption was set to true on parent bottomStackNavigator (see repro).The affected logic was previously introduced or changed by following PRs:
The removed
_hasLayoutwas initially added by #600 in order to resolve an issue: #432.However the logic was later changed by #613 in order to fix another issue and the added
_hasLayoutmay not fix anything eventually, as stated by this comment.Fixes #1645.
Changes
_hasLayoutvariableScreenshots / GIFs
Before
Screen.Recording.2024-06-17.at.17.56.22.mov
After
Screen.Recording.2024-06-17.at.17.55.15.mov
Test code and steps to reproduce
Test1645.jsrepro to test examplesTest432.tsxrepro to test examplesChecklist