fix(examples): allow project node_modules to be used #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, if it fixes the crash then we should proceed. |
alduzy
approved these changes
Jun 21, 2024
|
Could you document it? Cause I just checked and don't see an issue on my end. I'm proceeding here. As you said, if there is some other probelm we will handle it separately. |
alduzy
pushed a commit
that referenced
this pull request
Jun 28, 2024
## Description The custom resolver implemented in our `metro.config.js` right now most likely does not conver all cases. When working on my PR with modals for Android I've added `jotai` package and received errors from bundler that this package is not found, because: 1. it was not present in any nearby `node_modules` - the file that requries it resides now in `apps/test-examples`, thus application `node_modules` are not checked by default, 2. only our custom resolver looks into apps `node_modules` & fails to resolve this package. I haven't investigated why it does not work for `jotai` in particular, because more general solution is to just let the default module resolution algorithm look into application `node_modules` as it should always do. ## Changes Added application `node_modules` to the list of additional node modules in metro config of each example application. ## Test code and steps to reproduce Install `jotai` w/o this change, require it in any example and try to run the application. Then apply changes from this PR and see it works well. ## Checklist - [ ] Ensured that CI passes
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…n#2200) ## Description The custom resolver implemented in our `metro.config.js` right now most likely does not conver all cases. When working on my PR with modals for Android I've added `jotai` package and received errors from bundler that this package is not found, because: 1. it was not present in any nearby `node_modules` - the file that requries it resides now in `apps/test-examples`, thus application `node_modules` are not checked by default, 2. only our custom resolver looks into apps `node_modules` & fails to resolve this package. I haven't investigated why it does not work for `jotai` in particular, because more general solution is to just let the default module resolution algorithm look into application `node_modules` as it should always do. ## Changes Added application `node_modules` to the list of additional node modules in metro config of each example application. ## Test code and steps to reproduce Install `jotai` w/o this change, require it in any example and try to run the application. Then apply changes from this PR and see it works well. ## Checklist - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The custom resolver implemented in our
metro.config.jsright now most likely does not conver all cases.When working on my PR with modals for Android I've added
jotaipackage and received errors from bundler that this package is not found,because:
node_modules- the file that requries it resides now inapps/test-examples, thus applicationnode_modulesare not checked by default,node_modules& fails to resolve this package.I haven't investigated why it does not work for
jotaiin particular, because more general solution is to just let the default module resolution algorithm look intoapplication
node_modulesas it should always do.Changes
Added application
node_modulesto the list of additional node modules in metro config of each example application.Test code and steps to reproduce
Install
jotaiw/o this change, require it in any example and try to run the application.Then apply changes from this PR and see it works well.
Checklist