-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS): add shadow to custom push pop transitions #2239
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5c864c4
feat(iOS): add shadow to custom push pop transitions
maksg 138f6d7
feat(iOS): add prop to enable full screen swipe shadow
maksg b7055c5
fix: transition shadow Android props and typos
maksg 6229afb
chore: set default fullScreenGestureShadowEnabled value during destru…
maksg 577dfc0
Merge branch 'main' into @maksg/shadow-during-custom-push-pop
maksg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule react-navigation
updated
2 files
+10 −0 | packages/native-stack/src/types.tsx | |
+6 −0 | packages/native-stack/src/views/NativeStackView.native.tsx |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -202,6 +202,7 @@ const RouteView = ({ | |||||||
let { | ||||||||
customAnimationOnSwipe, | ||||||||
fullScreenSwipeEnabled, | ||||||||
fullScreenSwipeShadowEnabled, | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
gestureResponseDistance, | ||||||||
stackAnimation, | ||||||||
stackPresentation = 'push', | ||||||||
|
@@ -224,6 +225,10 @@ const RouteView = ({ | |||||||
} | ||||||||
} | ||||||||
|
||||||||
if (fullScreenSwipeShadowEnabled === undefined) { | ||||||||
fullScreenSwipeShadowEnabled = false; | ||||||||
} | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
|
||||||||
if (index === 0) { | ||||||||
// first screen should always be treated as `push`, it resolves problems with no header animation | ||||||||
// for navigator with first screen as `modal` and the next as `push` | ||||||||
|
@@ -294,6 +299,7 @@ const RouteView = ({ | |||||||
customAnimationOnSwipe={customAnimationOnSwipe} | ||||||||
freezeOnBlur={freezeOnBlur} | ||||||||
fullScreenSwipeEnabled={fullScreenSwipeEnabled} | ||||||||
fullScreenSwipeShadowEnabled={fullScreenSwipeShadowEnabled} | ||||||||
hideKeyboardOnSwipe={hideKeyboardOnSwipe} | ||||||||
homeIndicatorHidden={homeIndicatorHidden} | ||||||||
gestureEnabled={isAndroid ? false : gestureEnabled} | ||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with bumping
react-navigation
in such way is that it will be overridden by next PR that tries to do the same. We need a PR toreact-navigation
, merge it there to main & bumpreact-navigation
here to new main revision.This change should be reverted & we should wait for progress on
react-navigation
PR.