fix: removed deprecated test that caused fabric bundle failure #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboba
approved these changes
Jul 11, 2024
|
ok then |
kkafar
approved these changes
Jul 16, 2024
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…are-mansion#2245) ## Description This PR removes `Test898`. Importing this test in `apps/src/tests/index.ts` caused FabricExample bundling failure. The test itself was introduced by this [PR](software-mansion#898) in order to test reanimated v2. Idk why the import causes bundle to fail, but it seems reasonable to just remove it rather than debug further as the test is redundant since there is a newer version of reanimated. ## Changes - remove `Test898` <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce - try running any test using FabricExample when the import is there and when it's not ## Checklist - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
Test898. Importing this test inapps/src/tests/index.tscaused FabricExample bundling failure.The test itself was introduced by this PR in order to test reanimated v2. Idk why the import causes bundle to fail, but it seems reasonable to just remove it rather than debug further as the test is redundant since there is a newer version of reanimated.
Changes
Test898Test code and steps to reproduce
Checklist