fix: Fixes to sync archs scripts #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciekstosio
changed the title
maciekstosio
changed the title
|
Hey, is this ready to be reviewed? |
|
@kkafar it's ready to review |
maciekstosio
deleted the
@maciekstosio/Add-small-fixes-to-arch-sync-scripts
branch
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
This was referenced Aug 31, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description Fixes to software-mansion#2224, that came out in other repos. ## Changes - Bump version of GitHub actions - Fix warning when trying to copy non existing codegen interface ## Test code and steps to reproduce Duplicate `android/src/paper/java/com/facebook/react/viewmanagers/RNSSearchBarManagerDelegate.java` with name change for example with ` copy` at the end. Before it would fail because file wouldn't be found. Now there will be warning in logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes to #2224, that came out in other repos.
Changes
Test code and steps to reproduce
Duplicate
android/src/paper/java/com/facebook/react/viewmanagers/RNSSearchBarManagerDelegate.javawith name change for example withcopyat the end. Before it would fail because file wouldn't be found. Now there will be warning in logs.