fix(android): disappearing search icon on opening transparent modal #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
reviewed
Jul 31, 2024
|
@kkafar I added a brief explanation to the description |
kkafar
requested changes
Aug 6, 2024
There was a problem hiding this comment.
Okay, so the onPrepareOptionsMenu method is called for every screen on the stack.
Hypothesis: it seems that Android looks for closest menu in view hierarchy to update, hence if a screen does not have a header we try to update our sibling's header.
Usually this works fine because we unmount the screen below on the stack. When transparent stack presentation is in use we try to update the sibling's toolbar with transparent screen's null header config, thus effectively clearing it, leading to the bug.
The logic fix is ok, however we need to tune it up a bit. See below.
Good job overall!
android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt
Outdated
Show resolved
Hide resolved
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…oftware-mansion#2274) ## Description This PR fixes disappearing search icon of the previous screen when navigating to a transparent modal with hidden header. When navigating to a screen with `presentation: "transparentModal"` and `headerShown: false` the toolbar menu was unnecessarily updated with new screen's options. The update caused the search icon of the previous screen (still visible in the background) to disappear. Fixes software-mansion#2271 . ## Changes - added `Test2271.tsx` repro - updating the toolbar menu conditionally ## Screenshots / GIFs ### Before https://github.com/user-attachments/assets/390f054b-b003-4b7f-b6f5-9aa9fd936dca ### After https://github.com/user-attachments/assets/cb1fc795-c7a3-4514-9bb5-b7e1995d0b90 ## Test code and steps to reproduce - use `Test2271.tsx` for repro ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes disappearing search icon of the previous screen when navigating to a transparent modal with hidden header.
When navigating to a screen with
presentation: "transparentModal"andheaderShown: falsethe toolbar menu wasunnecessarily updated with new screen's options. The update caused the search icon of the previous screen (still visible in the background) to disappear.
Fixes #2271 .
Changes
Test2271.tsxreproScreenshots / GIFs
Before
Screen.Recording.2024-07-31.at.18.42.53.mov
After
Screen.Recording.2024-07-31.at.18.41.43.mov
Test code and steps to reproduce
Test2271.tsxfor reproChecklist