fix(Android,Fabric): add missing DoNotStrip annotation to JNI-accessed methods
#2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alduzy
approved these changes
Aug 8, 2024
|
I can confirm this fixes it, once deployed I stopped seeing the crash in #2286 |
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…sed methods (software-mansion#2290) ## Description Due to missing `DoNotStrip` annotations proguard could treat the class & methods as unused (as reported in software-mansion#2286) and remove them completely. Possibly fixes software-mansion#2286. ## Changes Annotate `ScreenDummyLayoutHelper` class & all method accessed via JNI. ## Test code and steps to reproduce Haven't triggerred the error localy, relying on report in software-mansion#2286 ## Checklist - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to missing
DoNotStripannotations proguard could treat the class & methods as unused (as reported in #2286)and remove them completely.
Possibly fixes #2286.
Changes
Annotate
ScreenDummyLayoutHelperclass & all method accessed via JNI.Test code and steps to reproduce
Haven't triggerred the error localy, relying on report in #2286
Checklist