Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix placement of Hero on big screens #2305

Merged
merged 2 commits into from
Aug 29, 2024
Merged

docs: Fix placement of Hero on big screens #2305

merged 2 commits into from
Aug 29, 2024

Conversation

patrycjakalinska
Copy link
Contributor

Before:
image

After:
image

tboba
tboba approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@tboba tboba merged commit b7a51fc into main Aug 29, 2024
1 check passed
@tboba tboba deleted the @patrycjakalinska/big-screen-fix branch August 29, 2024 09:52
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
@patrycjakalinska @ja1ns
docs: Fix placement of Hero on big screens (software-mansion#2305)
e8ff308 
Before:

![image](https://github.com/user-attachments/assets/2cfbec89-ddd2-46b0-ac1f-aadd7a8271d9)

After:
<img width="1227" alt="image"
src="https://github.com/user-attachments/assets/12ac3764-9630-4eea-90c0-7770882d6e1e">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tboba tboba tboba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrycjakalinska @tboba