fix(Android): incorrect childCount in removeViewAt when using flatlist on fabric #2307
+43
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intents to fix the crash when navigating back from a screen with FlatList on the new architecture. The crash was caused by miscalculated
childCount
of the list.Earlier on I found out that setting the removeClippedSubviews option to false (defaults to true on Android) in the FlatList fixes the problem.
This PR is rather a quick fix with an extra condition, that adds simple views in place of the miscalculated ones in
startTransitionRecursive
function if there's a FlatList withremoveClippedSubviews
option set.Fixes #2282.
Changes
Test2282.tsx
reprostartTransitionRecursive
functionTest code and steps to reproduce
Test2282.tsx
reproChecklist