fix(Android): Request layout manually for CustomToolbar below Android API 29 #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow Android API 29 Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
tboba
force-pushed
the
@tboba/fix-android-adjustpan-layout
branch
from
b277f6c
to
e3972d7
Compare
kkafar
approved these changes
Sep 12, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
… API 29 (software-mansion#2332) ## Description On Android API 29, while using `windowSoftInputMode` with `adjustPan` option, requestLayout is not being called while subviews are being added. That's because while ScreenStackHeaderConfig adds view to the toolbar, onMeasure is being called and even if we're calling `requestLayout` on parent, Android is returning from requesting the layout, as there's somehow ongoing layout. This is not the case for Android API 30 and higher. The solution is to request another layout via ReactChoreographer (same as in ScreenContainer) to call our own layout callback on the next frame. ## Changes - Request layout via ReactChoreographer on `requestLayout` call in CustomToolbar class ## Screenshots / GIFs <details><summary>BEFORE</summary>  </details> <details><summary>AFTER</summary>  </details> ## Test code and steps to reproduce Use `Test2332.tsx` test case to check whether this PR works properly. ## Checklist - [x] Included code example that can be used to test this change - [ ] Ensured that CI passes --------- Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Android API 29, while using
windowSoftInputModewithadjustPanoption, requestLayout is not being called while subviews are being added. That's because while ScreenStackHeaderConfig adds view to the toolbar, onMeasure is being called and even if we're callingrequestLayouton parent, Android is returning from requesting the layout, as there's somehow ongoing layout. This is not the case for Android API 30 and higher.The solution is to request another layout via ReactChoreographer (same as in ScreenContainer) to call our own layout callback on the next frame.
Changes
requestLayoutcall in CustomToolbar classScreenshots / GIFs
BEFORE
AFTER
Test code and steps to reproduce
Use
Test2332.tsxtest case to check whether this PR works properly.Checklist