fix(iOS): modal not presenting when deep in stack #2335
Conversation
Co-authored-by: Kacper Kafara <kacperkafara@gmail.com>
|
|
||
| UIViewController *lastModalVc = [self lastFromPresentedViewControllerChainStartingFrom:firstModalToBeDismissed]; | ||
|
|
||
| if (lastModalVc != firstModalToBeDismissed) { | ||
| [lastModalVc dismissViewControllerAnimated:shouldAnimate completion:finish]; | ||
| return; | ||
| } |
There was a problem hiding this comment.
Have you checked if this doesn't break anything else? According to blame, this check has been here added in purpose. See: 471127e
Could you check if Test1829.tsx works properly with changes from this PR?
There was a problem hiding this comment.
Yes, we had a call with @kkafar trying to figure out the proper fix prior to making this PR and we checked a few scenarios including Test1829.
Unless there is some hidden scenario which breaks by this, there shouldn't be any issues with the removal of those lines.
There was a problem hiding this comment.
Hey, I confirm that we tested this code and it seems that some other changes in code made the to-be-removed lines obsolete or even "misbehaving" (they introduce a bug now, instead of improving the situation).
We've also tested common cases and navigation scenarios & it seems we're good on this front.
Let's solve the merge conflicts and we can proceed.
|
Also for some reason iOS e2e CI is failing - I've restarted it. Let's make sure it passes. |
|
@kkafar iOS tests seem to be failing since last week so I'm not sure what's exactly the cause of that. Anyway, I've resolved conflicts. |
) ## Description When 3 screens with a ‘modal’ presentation mode are stacked, navigating to a screen outside of the current stack is not functioning correctly. ## Changes Removed dismissing logic for `lastModalVc`. ## Screenshots / GIFs ### Before https://github.com/user-attachments/assets/d4991253-52f1-4f35-8698-242d98b218d1 ### After https://github.com/user-attachments/assets/571ebd45-7319-4225-ab5b-4f68027f4f09 ## Test code and steps to reproduce `TestModalNavigation` was added to tests. ## Checklist - [x] Included code example that can be used to test this change - [ ] Ensured that CI passes Co-authored-by: Kacper Kafara <kacperkafara@gmail.com>
Description
When 3 screens with a ‘modal’ presentation mode are stacked, navigating to a screen outside of the current stack is not functioning correctly.
Changes
Removed dismissing logic for
lastModalVc.Screenshots / GIFs
Before
30-40-xoxak-qawl4.mp4
After
Simulator.Screen.Recording.-.iPad.Pro.13-inch.M4.-.2024-09-05.at.14.01.40.mp4
Test code and steps to reproduce
TestModalNavigationwas added to tests.Checklist