feat(iOS): sheetInitialDetent support #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
reviewed
Oct 1, 2024
kkafar
reviewed
Oct 1, 2024
|
@kkafar I updated the PR. Tested on iOS 15.5 and iOS 18 successfully |
kkafar
reviewed
Oct 2, 2024
Comment on lines
+892
to
+893
| if (@available(iOS 16.0, *)) { | ||
| if (_sheetAllowedDetents.count > 0) { |
There was a problem hiding this comment.
_sheetAllowedDetents.count > 0 is true in most cases. Nothing would happen on iOS < 16 as such case isn't handled inside the condition. After swapping them both versions work correctly
kkafar
approved these changes
Oct 2, 2024
Comment on lines
+892
to
+893
| if (@available(iOS 16.0, *)) { | ||
| if (_sheetAllowedDetents.count > 0) { |
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description This PR adds `sheetInitialDetent` support to iOS and fixes detents logic on iOS < 16. This functionality depends on changes made in this PR: react-navigation/react-navigation#12032 ## Changes - supporting `sheetInitialDetent` on iOS - modified `Test2002.tsx` repro - updated README definition to match types - fixed `sheetAllowedDetents` on iOS < 16 <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce - Use `Test2002.tsx` repro ## Checklist - [x] Included code example that can be used to test this change - [x] Updated documentation: <!-- For adding new props to native-stack --> - [x] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
sheetInitialDetentsupport to iOS and fixes detents logic on iOS < 16.This functionality depends on changes made in this PR: react-navigation/react-navigation#12032
Changes
sheetInitialDetenton iOSTest2002.tsxreprosheetAllowedDetentson iOS < 16Test code and steps to reproduce
Test2002.tsxreproChecklist