fix: bring back headers when using "modal" presentation on Android #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Duzy <alex.duzy@swmansion.com>
kkafar
force-pushed
the
@kkafar/bring-back-headers-in-modals
branch
from
385003b
to
a7a07a1
Compare
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…oftware-mansion#2372) ## Description Recently, when adding formSheets I've also merged some code for future modals implementation. When detaching the yet-unused code for modals from being used I've forgotten about one code place, causing the header to not be created. `modal` presentation is rather not widely used on Android, because it has no real differences from `push`, however I'm restoring the old behavior for the sake of backward compatibility. Kudos to @alduzy for noticing the issue. ## Changes * Fixed the condition that prevents the header from being created on Android, right now header is not created only for `formSheet` stack presentation. ## Test code and steps to reproduce `Test1649` - set 'modal' stack presentation to any screen and do not disable the header. See that it now works. ## Checklist - [x] Included code example that can be used to test this change - [ ] Ensured that CI passes Co-authored-by: Alex Duzy <alex.duzy@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently, when adding formSheets I've also merged some code for future modals implementation.
When detaching the yet-unused code for modals from being used I've forgotten about one code place,
causing the header to not be created.
modalpresentation is rather not widely used on Android, because it has no real differences frompush,however I'm restoring the old behavior for the sake of backward compatibility.
Kudos to @alduzy for noticing the issue.
Changes
is not created only for
formSheetstack presentation.Test code and steps to reproduce
Test1649- set 'modal' stack presentation to any screen and do not disable the header. See that it now works.Checklist