fix: prevent crash when there is no appearance model built #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciekstosio
approved these changes
Oct 3, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…mansion#2375) ## Description I haven't investigated it carefully, but there were case when updating `sheetCornerRadius` the appearance model has not been built yet leading to a crash when casting to a non-null type. Additionally, this PR prevents calls to `onSheetCornerRadiusUpdate` when not in `formSheet` presentation or not in native stack. ## Changes * Prevent calls to `onSheetCornerRadiusUpdate` when not in `formSheet` presentation. * Check for nullish view background before attempt to set the corner radius. * Update the corner radius after all updates are applied, so that the `stackPresentation` has change of being updated. ## Test code and steps to reproduce `Test1649`. Try setting the corner radius now, should work properly. ## Checklist - [x] Included code example that can be used to test this change - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I haven't investigated it carefully, but there were case when updating
sheetCornerRadiusthe appearancemodel has not been built yet leading to a crash when casting to a non-null type.
Additionally, this PR prevents calls to
onSheetCornerRadiusUpdatewhen not informSheetpresentationor not in native stack.
Changes
onSheetCornerRadiusUpdatewhen not informSheetpresentation.stackPresentationhas change of being updated.Test code and steps to reproduce
Test1649. Try setting the corner radius now, should work properly.Checklist