fix: check for surplus values in sheet detents array not only in dev mode #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciekstosio
approved these changes
Oct 4, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…mode (software-mansion#2387) ## Description Previous code reduced detent array to three values on Android only in dev mode - this is undesired. We want to always do it. ## Changes Moved the slicing operation out of check for dev mode. ## Test code and steps to reproduce `Test1649`, pass more than 3 values on Android, see that it works. ## Checklist - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous code reduced detent array to three values on Android only in dev mode - this is undesired.
We want to always do it.
Changes
Moved the slicing operation out of check for dev mode.
Test code and steps to reproduce
Test1649, pass more than 3 values on Android, see that it works.Checklist