fix(Android): do not crash in case background can not be casted to MaterialShapeDrawable #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…terialShapeDrawable (software-mansion#2388) ## Description It turns out, that this check: software-mansion@b2dab78 was necessary, and I forgot about it while applying the code review. Current code will crash if `background != null && !(background is MaterialShapeDrawable)`, so e.g. when `background is ColorDrawable`. We don't wanna fail in this case. ## Changes Allowed the cast to fail instead of throwing exception, when casting background to `MaterialShapeDrawable`. One thing that concerns me ## Test code and steps to reproduce `Test1649` ## Checklist - [ ] Included code example that can be used to test this change - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out, that this check: b2dab78 was necessary,
and I forgot about it while applying the code review.
Current code will crash if
background != null && !(background is MaterialShapeDrawable), so e.g. whenbackground is ColorDrawable.We don't wanna fail in this case.
Changes
Allowed the cast to fail instead of throwing exception, when casting background to
MaterialShapeDrawable.One thing that concerns me
Test code and steps to reproduce
Test1649Checklist