fix(Android,Fabric): invalid behaviour of fitToContents
sheet detent
#2398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes invalid behaviour of
fitToContents
sheet detent on Fabric.The erroneous behaviour has been caused by different order of updates on Fabric relative to Paper.
On Fabric
onCreateView
(the place where bottom sheet behaviour is created) is called much later,Because of this the layoutCallback from
ScreenContentWrapper
fails to set proper sheet height,as the
sheetBehaviour
is stillnull
.Changes
Screen
now keeps weak reference toScreenContentWrapper
and queries it when needed during behaviour configuration.Test code and steps to reproduce
Test1649
, chantesheetInitialDetents
tofitToContents
and see that it now works on Fabric.Checklist