Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: expose library compatibilityFlags with new flag regarding header implementation #2411

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Oct 16, 2024

Description

This PR introduces new compatiblityFlags object to the library public API.
It is meant as a source of truth for the library consumers (especially react-navigation) to allow them to adjust to breaking changes
done in this library.

I've decided to go with single object with fields instead of individual constants, because it makes it easier for handling,
we don't have to change public exports every time we add something, it makes it easier to add/remove a flag.

Changes

  1. Created & exposed compatiblityFlags object,
  2. added usesHeaderFlexboxImplementation,
  3. moved old flags into the object.

Test code and steps to reproduce

N/A

Checklist

  • Ensured that CI passes

Copy link
Member

@alduzy alduzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkafar kkafar merged commit 71d862f into main Oct 16, 2024
3 checks passed
@kkafar kkafar deleted the @kkafar/expose-feature-flags branch October 16, 2024 12:32
@kkafar kkafar self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants