Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CMake changes needed for RN 0.76.0 #2415

Closed
wants to merge 1 commit into from

Conversation

mysport12
Copy link

Description

CMake changes required for RN 0.76.0

See below discussion for change background
react-native-community/discussions-and-proposals#816

Note that the RN provided flag is still not populating in 0.76.0-rc.5 and that the flag used in this PR is one being used by a number of other libraries.

Changes

Fixes Android build errors on RN 0.76.0

Test code and steps to reproduce

  • Run an app with RN 0.76.0 without the changes and note the android build failures
  • Run the same app again with the changes applied and note the build succeeds

Checklist

@mysport12 mysport12 changed the title [Fix]: CMake changes needed for RN 0.76.0 fix: CMake changes needed for RN 0.76.0 Oct 17, 2024
@mysport12
Copy link
Author

@maciekstosio I noticed you incorporated some of these changes (albeit without the conditionals) in your bump example to 0.76.0-rc.5 PR (#2407). Not sure if you want to consolidate this change into that PR. Whichever is easiest.

@jbroma
Copy link

jbroma commented Oct 17, 2024

can confirm this works nicely with patched 3.34.0 version of react-native-screens 👍
Would be nice to get this released in a 3.X version as well to remain compatible with RN 76

@maciekstosio
Copy link
Contributor

maciekstosio commented Oct 18, 2024

@mysport12 Thanks for the PR! I consolidated your change into #2407, and changed the condition so you can use it with paper on 0.76, you can see it here: fa8e8fe

@maciekstosio
Copy link
Contributor

@jbroma We will prepare a 3.x version, but for now we're pushing with 4.x.

@maciekstosio
Copy link
Contributor

maciekstosio commented Oct 21, 2024

We merged 0.76 support (#2407), so I'm closing this PR. Thanks for contributing! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants