Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Android): patch potential issues with Android build since RN lib-merge in 0.76 #2602

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Jan 7, 2025

Description

Fixes #2463

I haven't been able to reproduce the issue, however multiple people reported & confirmed it

Thanks @vadzimk for pointing these out.

When adding support for 0.76.0 we overlooked that we relied on RN library structure (and naming) not only in CMake build but also in Gradle configuration.

I've looked up whether reanimated team did this - and they did & we will follow their lead here.

Changes

Added libfbjni & libreactnative to exclude list so that these are subject of duplicated dependency error.

Test code and steps to reproduce

WIP

Checklist

@kkafar kkafar requested a review from WoLewicki January 7, 2025 09:46
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it works 🤷‍♂️

@kkafar kkafar merged commit bc24731 into main Jan 7, 2025
4 checks passed
@kkafar kkafar deleted the @kkafar/0.76-library-unification-patch-1 branch January 7, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library Conflict with libfbjni.so
2 participants