Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor findHostInstance following reanimated #2609

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
b1e3464
mark: start upgrade
kkafar Dec 18, 2024
f4121bd
Node deps in FE
kkafar Dec 18, 2024
3d52718
Code changes for FabricExample
kkafar Dec 18, 2024
393d686
Reinstall native iOS deps
kkafar Dec 18, 2024
c8c4635
TOREVERT: Remove dependency on gesture-handler and reanimated
kkafar Dec 18, 2024
e26d131
TOREVERT: use only single test in apps
kkafar Dec 18, 2024
428bc0a
TOREVERT: update podfiles after removal of GH and REA
kkafar Dec 18, 2024
7ce428a
Add AppDelegate.swift to project targets in FE
kkafar Dec 18, 2024
c1b9ac4
Add missing bridging header
kkafar Dec 18, 2024
92a6ee4
Merge branch 'main' into @kkafar/support-0.77
kkafar Dec 18, 2024
09af0d7
Update yarn lock once again
kkafar Dec 18, 2024
a8cd2b5
feat: Use `BaseReactPackage` instead of `TurboReactPackage` (#2546)
mrousavy Dec 18, 2024
7c89096
Bump RN in libarary to 0.77.0-rc.3
kkafar Dec 19, 2024
f968e05
Update view manager interfaces & delegates for Paper
kkafar Dec 19, 2024
ad13f41
Bump RNSAC to 5.0.0 in FE
kkafar Dec 19, 2024
381ae77
POSSIBLY TO REVERT: Remove patches for gesture handler 2.20.0
kkafar Dec 19, 2024
1bc4a9c
Update patch for react-native-safe-area-context
kkafar Dec 19, 2024
937c5e0
All Android + iOS non-appdelegate-related changes for Example
kkafar Dec 19, 2024
d8daf6c
Rest of iOS changes for Example
kkafar Dec 19, 2024
7ad8e06
Workaround for autolinking on older rncli versions
kkafar Dec 20, 2024
13905c1
Merge branch 'main' into @kkafar/support-0.77
kkafar Dec 30, 2024
6216502
Bump RN to rc.4
kkafar Dec 30, 2024
cf86e79
Bump RN to rc.6
kkafar Jan 8, 2025
2c690d4
Restore reanimated with a patch
kkafar Jan 9, 2025
6a31905
Restore gesture-handler (current main)
kkafar Jan 9, 2025
683905d
Restore App.tsx
kkafar Jan 9, 2025
48b0a89
Restore apps/tests/index.ts
kkafar Jan 9, 2025
b8d896c
Update locks in hope that yarn lets my CI run
kkafar Jan 9, 2025
af50c66
Update implementation of findHostInstance followin reanimated
kkafar Jan 9, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Example/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ ruby ">= 2.6.10"
# Exclude problematic versions of cocoapods and activesupport that causes build failures.
gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1'
gem 'activesupport', '>= 6.1.7.5', '!= 7.1.0'
gem 'xcodeproj', '< 1.26.0'
4 changes: 2 additions & 2 deletions Example/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ buildscript {
minSdkVersion = 24
compileSdkVersion = 35
targetSdkVersion = 34
ndkVersion = "26.1.10909125"
kotlinVersion = "1.9.24"
ndkVersion = "27.1.12297006"
kotlinVersion = "2.0.21"
}
repositories {
google()
Expand Down
30 changes: 30 additions & 0 deletions Example/ios/AppDelegate.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import UIKit
import React
import React_RCTAppDelegate
import ReactAppDependencyProvider

@main
class AppDelegate: RCTAppDelegate {
override func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey : Any]? = nil) -> Bool {
self.moduleName = "ScreensExample"
self.dependencyProvider = RCTAppDependencyProvider()

// You can add your custom initial props in the dictionary below.
// They will be passed down to the ViewController used by React Native.
self.initialProps = [:]

return super.application(application, didFinishLaunchingWithOptions: launchOptions)
}

override func sourceURL(for bridge: RCTBridge) -> URL? {
self.bundleURL()
}

override func bundleURL() -> URL? {
#if DEBUG
RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "index")
#else
Bundle.main.url(forResource: "main", withExtension: "jsbundle")
#endif
}
}
5 changes: 0 additions & 5 deletions Example/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ target 'ScreensExample' do
:app_path => "#{Pod::Config.instance.installation_root}/.."
)

target 'ScreensExampleTests' do
inherit! :complete
# Pods for testing
end

post_install do |installer|
# https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L197-L202
react_native_post_install(
Expand Down
Loading
Loading