Skip to content

Commit

Permalink
chore: set library namespace in build script (#2005)
Browse files Browse the repository at this point in the history
Since AGP 8.0 project namespace must be set inside build script.
It is also the recommended way in Android docs.

It is also recommended, that the package name definition is removed from Android manifest file, but I've had some problems in react-native-screens with RN CLI crashing (as it was expecting the package field to exist) & according to this conversation it'll still be legal to leave package name definition in Android manifest file as long as it exactly matches the value in build script.
  • Loading branch information
kkafar authored Mar 23, 2023
1 parent 63bf270 commit 998c3e3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ def safeExtGet(prop, fallback) {

android {
compileSdkVersion safeExtGet('compileSdkVersion', 28)
namespace "com.horcrux.svg"

// Used to override the NDK path/version on internal CI or by allowing
// users to customize the NDK path/version from their root project (e.g. for M1 support)
Expand Down

0 comments on commit 998c3e3

Please sign in to comment.