Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird Display in RN V0.68 New Architecture Enabled #1709

Closed
myckhel opened this issue Feb 26, 2022 · 10 comments
Closed

Weird Display in RN V0.68 New Architecture Enabled #1709

myckhel opened this issue Feb 26, 2022 · 10 comments

Comments

@myckhel
Copy link

myckhel commented Feb 26, 2022

Bug

Svg does not show in rn v0.68.0-rc.2 with new architecture enabled instead it shows a strange Text of 'RNSVGRect'
WhatsApp Image 2022-02-26 at 02 25 32 (1) WhatsApp Image 2022-02-26 at 02 25 32

react-native init CleanProject --version 0.68.0-rc.2
cd CleanProject/
yarn add react-native-svg
modify android/gradle.properties -> and change to newArchEnabled=true
run the app -> react-native run-android

Environment info

React native info output:

 System:
    OS: macOS 11.6.2
    CPU: (4) x64 Intel(R) Core(TM) m3-7Y32 CPU @ 1.10GHz
    Memory: 311.86 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.2 - /usr/local/bin/node
    Yarn: 3.1.1 - /usr/local/bin/yarn
    npm: 8.1.2 - /usr/local/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.11.2 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3
    Android SDK: Not Found
  IDEs:
    Android Studio: 2020.3 AI-203.7717.56.2031.7935034
    Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.10 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2 
    react-native: 0.68.0-rc.2 => 0.68.0-rc.2 
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Library version: ^12.1.1

Steps To Reproduce

  1. react-native init CleanProject --version 0.68.0-rc.2
  2. cd CleanProject/
  3. yarn add react-native-svg
  4. modify android/gradle.properties -> and change to newArchEnabled=true
  5. yarn android

Describe what you expected to happen:

  1. Display svg correctly
@myckhel
Copy link
Author

myckhel commented Feb 26, 2022

RSSVG Not supported by fabric yet. reactwg/react-native-releases#13 (reply in thread)

@kelset
Copy link

kelset commented Feb 28, 2022

@myckhel any chance you can actually prepare some repro code that shows the problem? your repro steps don't contain any code 😅

@myckhel
Copy link
Author

myckhel commented Feb 28, 2022

Working on it.

Thanks

@myckhel
Copy link
Author

myckhel commented Feb 28, 2022

@kelset Example repo has been created at https://github.com/myckhel/svg-fabric-unsupported

Running App

yarn install && yarn android

Screenshot_1646063603

@sdevansh96
Copy link

hi,
I am also facing the issue in android using React Native Fabric architecture.
Any way to fix this?

@pjc0247
Copy link

pjc0247 commented Apr 25, 2022

Same here (rn 0.68.1)

@AlirezaHadjar
Copy link

AlirezaHadjar commented Apr 30, 2022

Apparently react-native-svg is not fully compatible with new architecture yet. #1731

@pjc0247
Copy link

pjc0247 commented May 2, 2022

#1754

@andresribeiro
Copy link

#1754

even after this PR has been merged, some components are still not Fabric compatible

@WoLewicki
Copy link
Member

I think we can close this issue now since Fabric support is released. Although, if you want to use it on Android in RN version < 0.70.0-rc.3, you need to link the components manually. There is already an issue for how to do it which I plan to resolve ASAP: #1839. Feel free to comment here if something is wrong and we can always reopen it then.

Bibazavr added a commit to lad-tech/mobydick that referenced this issue Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants