Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.7.0] missing types #2453

Closed
efstathiosntonas opened this issue Sep 17, 2024 · 5 comments · Fixed by #2454
Closed

[15.7.0] missing types #2453

efstathiosntonas opened this issue Sep 17, 2024 · 5 comments · Fixed by #2454
Labels
bug Missing repro This issue need minimum repro scenario

Comments

@efstathiosntonas
Copy link

efstathiosntonas commented Sep 17, 2024

Description

After upgrading to 15.7.0 the types are missing because this line:

"types": "lib/typescript/index.d.ts",

should be(?): "types": "lib/typescript/src/index.d.ts",

Screenshot 2024-09-17 at 12 50 25

Steps to reproduce

  1. upgrade to 15.7.0
  2. boom, no types

Snack or a link to a repository

none

SVG version

15.7.0

React Native version

0.75.3

Platforms

Android, iOS, macOS, Web

JavaScript runtime

Hermes

Workflow

React Native

Architecture

Paper (Old Architecture)

Build type

None

Device

iOS simulator

Device model

No response

Acknowledgements

Yes

@github-actions github-actions bot added the Missing repro This issue need minimum repro scenario label Sep 17, 2024
Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@vovkasm
Copy link

vovkasm commented Sep 17, 2024

Actually issue does contain enough info. It's enough to compare value of "types" field in package.json and actual file locations in node_modules after installing.

@vovkasm
Copy link

vovkasm commented Sep 17, 2024

This issue most probably related to a089cc2#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0R24 which include additional folders to tsconfig.json, now bob (and typescript) builds not only src content, but also e2e and do not do folder aggregation ;-)
May be solution is distinct tsconfig.build.json used only for build without e2e folder.

@jakex7 jakex7 added the bug label Sep 17, 2024
@jakex7 jakex7 closed this as completed in 54790cd Sep 17, 2024
jakex7 added a commit that referenced this issue Sep 17, 2024
# Summary

Hot fix for #2453 missing types.
Closes #2453.
@efstathiosntonas
Copy link
Author

Thanks @jakex7 for the quick fix!

@jakex7
Copy link
Member

jakex7 commented Sep 17, 2024

Hello,
thank you for reporting this issue so quickly. I was able to resolve it in #2454, and the fix has been included in the v15.7.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Missing repro This issue need minimum repro scenario
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants