Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native crash in Android using svg with filter. #2529

Closed
jimbofoo opened this issue Nov 12, 2024 · 2 comments · Fixed by #2530
Closed

Native crash in Android using svg with filter. #2529

jimbofoo opened this issue Nov 12, 2024 · 2 comments · Fixed by #2530
Assignees
Labels
Missing info The user didn't precise the problem enough Missing repro This issue need minimum repro scenario

Comments

@jimbofoo
Copy link

Description

On android <SvgUri> crashes in native code: 

Fatal Exception: java.lang.NullPointerException
Attempt to invoke virtual method 'int com.horcrux.svg.FilterProperties$FeBlendMode.ordinal()' on a null object reference
com.horcrux.svg.FeBlendView.applyFilter (FeBlendView.java:73)
com.horcrux.svg.FilterView.applyFilter (FilterView.java:98)
com.horcrux.svg.RenderableView.render (RenderableView.java:393)
com.horcrux.svg.GroupView.drawGroup (GroupView.java:135)
com.horcrux.svg.GroupView.draw (GroupView.java:91)
com.horcrux.svg.RenderableView.render (RenderableView.java:483)
com.horcrux.svg.GroupView.drawGroup (GroupView.java:135)
com.horcrux.svg.GroupView.draw (GroupView.java:91)
com.horcrux.svg.RenderableView.render (RenderableView.java:483)
com.horcrux.svg.SvgView.drawChildren (SvgView.java:335)
com.horcrux.svg.SvgView.drawOutput (SvgView.java:281)
com.horcrux.svg.SvgView.onDraw (SvgView.java:134)

Steps to reproduce

use SvgUri with the above svg as src:
cb

<SvgUri
        uri={src}
        width={50}
        height={50}
      />

Snack or a link to a repository

SVG version

15.8.0

React Native version

0.76.1

Platforms

Android

JavaScript runtime

Hermes

Workflow

React Native

Architecture

Paper (Old Architecture)

Build type

None

Device

Real device

Device model

No response

Acknowledgements

Yes

@github-actions github-actions bot added the Missing repro This issue need minimum repro scenario label Nov 12, 2024
Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@github-actions github-actions bot added the Missing info The user didn't precise the problem enough label Nov 12, 2024
Copy link

Hey! 👋

It looks like you've omitted a few important sections from the issue template.

Please complete Snack or a link to a repository section.

@jakex7 jakex7 self-assigned this Nov 12, 2024
jakex7 added a commit that referenced this issue Nov 12, 2024
# Summary

Fixes #2529
`FeBlend` should have default blend mode set to `normal`

## Test Plan

Test case specified in #2529

## Compatibility

| OS      | Implemented |
| ------- | :---------: |
| Android |    ✅      |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing info The user didn't precise the problem enough Missing repro This issue need minimum repro scenario
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants