fix: toDataUrl line breaks #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
May 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://github.com/react-native-community/react-native-svg) | [`^15.2.0` -> `^15.3.0`](https://renovatebot.com/diffs/npm/react-native-svg/15.2.0/15.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg (react-native-svg)</summary> ### [`v15.3.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v15.3.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v15.2.0...v15.3.0) Minor release fixing some long-standing bugs. Thank you for your contributions! 🎉 #### What's Changed - Add dxguid.lib to release action by [@​Arthurmtro](https://github.com/Arthurmtro) in [https://github.com/software-mansion/react-native-svg/pull/2243](https://github.com/software-mansion/react-native-svg/pull/2243) - fix: set default strokeWidth to 1 on android by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2269](https://github.com/software-mansion/react-native-svg/pull/2269) - fix: remove `err` export by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2270](https://github.com/software-mansion/react-native-svg/pull/2270) - fix: Fix pod install not working with lower version of Cocoapods due to visionOS by [@​jihoon416](https://github.com/jihoon416) in [https://github.com/software-mansion/react-native-svg/pull/2240](https://github.com/software-mansion/react-native-svg/pull/2240) - fix: Fix static view config validation for RNSVGSvgViewAndroid by [@​fabriziocucci](https://github.com/fabriziocucci) in [https://github.com/software-mansion/react-native-svg/pull/2274](https://github.com/software-mansion/react-native-svg/pull/2274) - fix: radialGradient `r={0}` by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2271](https://github.com/software-mansion/react-native-svg/pull/2271) - fix: toDataUrl line breaks by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2272](https://github.com/software-mansion/react-native-svg/pull/2272) - fix: change android package name by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2275](https://github.com/software-mansion/react-native-svg/pull/2275) - fix: parsing `<` inside comments by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2277](https://github.com/software-mansion/react-native-svg/pull/2277) #### New Contributors - [@​Arthurmtro](https://github.com/Arthurmtro) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2243](https://github.com/software-mansion/react-native-svg/pull/2243) - [@​jakex7](https://github.com/jakex7) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2269](https://github.com/software-mansion/react-native-svg/pull/2269) - [@​jihoon416](https://github.com/jihoon416) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2240](https://github.com/software-mansion/react-native-svg/pull/2240) - [@​fabriziocucci](https://github.com/fabriziocucci) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2274](https://github.com/software-mansion/react-native-svg/pull/2274) **Full Changelog**: software-mansion/react-native-svg@v15.2.0...v15.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIm5wbSIsInJlbm92YXRlIl19--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the flag to include custom line breaks on
toDataUrlmethod. Some software could not read base64 with additional line break characters, so it could lead to corrupting the image (like in react-native-share). Fixes #1986.Test Plan
TestsExample->Test1986Compatibility