Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support filters on web #2346

Merged
merged 11 commits into from
Jul 25, 2024
Merged

feat: support filters on web #2346

merged 11 commits into from
Jul 25, 2024

Conversation

jakex7
Copy link
Member

@jakex7 jakex7 commented Jul 12, 2024

Summary

  • Export Filter and FeColorMatrix components on web
  • Change filter IDs in example to be unique*
  • Generate filter ID when using FilterImage*
  • Hide FilterImage example on web, since it's crashing the whole site (see feat: add new resolve web asset function #2334)

* ID on web has to be unique, otherwise it'll use the first element with that ID, even if they are in the separate SVG elements

Test Plan

run web-example app

Compatibility

OS Implemented
Web

@jakex7 jakex7 requested a review from WoLewicki July 12, 2024 09:59
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for #2334 with merging this one?

@jakex7
Copy link
Member Author

jakex7 commented Jul 19, 2024

Should we wait for #2334 with merging this one?

@WoLewicki
We don't have to. It's temporary disabling FilterImage example on web so everything else should work.

@WoLewicki
Copy link
Member

  • ID on web has to be unique, otherwise it'll use the first element with that ID, even if they are in the separate SVG elements

And it works the same in the browser? And at the same time is not part of the standard?

@jakex7 jakex7 requested a review from WoLewicki July 22, 2024 13:39
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment. Please answer it and then I think we are good to go 🚀

src/filter-image/FilterImage.tsx Outdated Show resolved Hide resolved
@jakex7 jakex7 merged commit ba7d775 into main Jul 25, 2024
1 check passed
@jakex7 jakex7 deleted the @jakex7/supportFiltersOnWeb branch July 25, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants