Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore invalid filter id #2360

Merged
merged 4 commits into from
Jul 22, 2024
Merged

fix: ignore invalid filter id #2360

merged 4 commits into from
Jul 22, 2024

Conversation

jakex7
Copy link
Member

@jakex7 jakex7 commented Jul 22, 2024

Summary

Closes #2356
Currently, when filter prop is defined, but there is no equivalent <Filter> component, on iOS nothing is rendered, with this fix this prop would be ignored, and the component should render as expected.

Test Plan

<Svg width="400" height="400" viewBox="0 0 124 124" fill="none">
  <Rect width="124" height="124" rx="24" fill="red" filter="url(#nonExistingFilterId)"/>
</Svg>

Affected platforms

OS Implemented
iOS

@jakex7 jakex7 requested a review from WoLewicki July 22, 2024 07:58
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please answer the comment and we can merge it then.

apple/RNSVGRenderable.mm Show resolved Hide resolved
apple/RNSVGRenderable.mm Outdated Show resolved Hide resolved
@jakex7 jakex7 merged commit 0d97399 into main Jul 22, 2024
4 checks passed
@jakex7 jakex7 deleted the @jakex7/fixInvalidFilterId branch July 22, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVGs with filters not displayed in v15.4.0 on iOS
2 participants