fix: implementation toDataURL for iOS platform both architectures #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakex7
approved these changes
Aug 13, 2024
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Sep 24, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://github.com/react-native-community/react-native-svg) | [`^15.5.0` -> `^15.7.1`](https://renovatebot.com/diffs/npm/react-native-svg/15.5.0/15.7.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg (react-native-svg)</summary> ### [`v15.7.1`](https://github.com/software-mansion/react-native-svg/releases/tag/v15.7.1) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v15.7.0...v15.7.1) Hotfix for v15.7.0 #### What's Changed - fix: exclude e2e from types in release by [@​jakex7](https://github.com/jakex7) in #[https://github.com/software-mansion/react-native-svg/pull/2454](https://github.com/software-mansion/react-native-svg/pull/2454) **Full Changelog**: software-mansion/react-native-svg@v15.7.0...v15.7.1 ### [`v15.7.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v15.7.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v15.6.0...v15.7.0) A minor release introducing the implementation of filter regions along with some bug fixes 🔧 #### What's Changed - fix: android svg scale 0 by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2424](https://github.com/software-mansion/react-native-svg/pull/2424) - feat: e2e snapshot tests by [@​CDFN](https://github.com/CDFN) in [https://github.com/software-mansion/react-native-svg/pull/2338](https://github.com/software-mansion/react-native-svg/pull/2338) - feat: add load method by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2427](https://github.com/software-mansion/react-native-svg/pull/2427) - fix: reset paint settings before drawing final bitmap by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2439](https://github.com/software-mansion/react-native-svg/pull/2439) - fix: add deprecated SvgViewManager to not break 0.72 by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2435](https://github.com/software-mansion/react-native-svg/pull/2435) - docs: introduce about webpack by [@​bohdanprog](https://github.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2434](https://github.com/software-mansion/react-native-svg/pull/2434) - docs: broken link in the readme file by [@​JohnAdib](https://github.com/JohnAdib) in [https://github.com/software-mansion/react-native-svg/pull/2443](https://github.com/software-mansion/react-native-svg/pull/2443) - feat: implement filter region by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2441](https://github.com/software-mansion/react-native-svg/pull/2441) - fix: Android group `opacity` prop by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2417](https://github.com/software-mansion/react-native-svg/pull/2417) - fix: render G offscreen only when it's needed (opacity != 1) by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2450](https://github.com/software-mansion/react-native-svg/pull/2450) - fix: transform scale on android by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2452](https://github.com/software-mansion/react-native-svg/pull/2452) #### New Contributors - [@​JohnAdib](https://github.com/JohnAdib) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2443](https://github.com/software-mansion/react-native-svg/pull/2443) **Full Changelog**: software-mansion/react-native-svg@v15.6.0...v15.7.0 ### [`v15.6.0`](https://github.com/software-mansion/react-native-svg/releases/tag/v15.6.0) [Compare Source](https://github.com/react-native-community/react-native-svg/compare/v15.5.0...v15.6.0) In this version, we've introduced support for React Native 0.75, Fabric support on Windows, and a few minor enhancements and fixes. Thank you to everyone who contributed! 🚀 #### What's Changed - chore: bump reanimated in macos example on paper by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2398](https://github.com/software-mansion/react-native-svg/pull/2398) - feat: add support int32 color by [@​bohdanprog](https://github.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2397](https://github.com/software-mansion/react-native-svg/pull/2397) - fix: implementation toDataURL for iOS platform both architectures by [@​bohdanprog](https://github.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2405](https://github.com/software-mansion/react-native-svg/pull/2405) - chore: cleanup example apps by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2408](https://github.com/software-mansion/react-native-svg/pull/2408) - feat(windows): add fabric support by [@​marlenecota](https://github.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/2321](https://github.com/software-mansion/react-native-svg/pull/2321) - feat: support dataUri for android platform by [@​bohdanprog](https://github.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2396](https://github.com/software-mansion/react-native-svg/pull/2396) - feat: introduce hitSlop prop by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2407](https://github.com/software-mansion/react-native-svg/pull/2407) - feat: rewrite `Svg` transform by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2403](https://github.com/software-mansion/react-native-svg/pull/2403) - Support-rgb(R%,G%,B%)-percentage by [@​hryhoriiK97](https://github.com/hryhoriiK97) in [https://github.com/software-mansion/react-native-svg/pull/2363](https://github.com/software-mansion/react-native-svg/pull/2363) - chore: bump apps to RN 0.75 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-svg/pull/2340](https://github.com/software-mansion/react-native-svg/pull/2340) - chore(deps): bump rexml from 3.2.6 to 3.3.3 in /tests-example by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-svg/pull/2410](https://github.com/software-mansion/react-native-svg/pull/2410) - chore: fix prettier by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2416](https://github.com/software-mansion/react-native-svg/pull/2416) - fix: do not resolve asset url for every object on web. by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2419](https://github.com/software-mansion/react-native-svg/pull/2419) - fix: transforms on macOS old arch by [@​jakex7](https://github.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2420](https://github.com/software-mansion/react-native-svg/pull/2420) #### New Contributors - [@​hryhoriiK97](https://github.com/hryhoriiK97) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2363](https://github.com/software-mansion/react-native-svg/pull/2363) **Full Changelog**: software-mansion/react-native-svg@v15.5.0...v15.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2233
Summary
Just wanted to say a big thank you to @imanderson for sorting out that issue with the toDataURL method in iOS and the old Arch. It’s awesome how you tracked down the problem and jumped in with a fix.
Problem: in iOS and old Arch, a callback on
toDataURLmethod will only be called the second time of asking.Here’s my PR based on his changes: PR
Test Plan
We can easily test that fix by running the
Test2233, we have an example of the problem.What are the steps to reproduce (after prerequisites)?
Compatibility