-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: web exports on prepare file #2430
base: main
Are you sure you want to change the base?
fix: web exports on prepare file #2430
Conversation
this worked for me. patched the package for now. thanks @migueldaipre |
Can we merge this? |
Hey @migueldaipre, thanks for sharing that! It looks good, however before we proceed with the merge, I’d like to gain a deeper understanding of the issue to prevent similar problems in the future. Could you share a repository where this issue can be reproduced? I’m not encountering it on our |
I'm currently using webpack for my expo project and ran into this issue |
this fix is highly important for apps supporting web and having last version of react native with new-arch activated. |
Until it is fixed, what I did was I cloned this repo, made the changes locally, ran the build command to generate the /web folder and replaced that in my yarn patch directory of this library. |
@migueldaipre thank you for this great work. Is it possible to fix the conflicts ? |
Hey there, I haven't had time to create a repro and the current project is private and large. But that's just down to how the code is imported, when I use “.” the error happens, when I change to “./index” the error doesn't happen. |
Anything we can do to get this in soon? I'm running into this issue as well. |
Here's a patch you can use with |
Summary
Fixes #2401
Fixes error in
prepare.ts
file that importshasTouchableProperty
from a '.' file.It's probably related to the way ESM works, I'm not sure. I base it on PR
Test Plan
Should work without error on web
web-working.mov
Compatibility
Checklist