Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support css variables for SvgCss #2459

Merged
merged 10 commits into from
Oct 2, 2024

Conversation

bohdanprog
Copy link
Member

Summary

Feature #2380

We want to add support for CSS variables when passing them to parse the SVG XML source function.

Test Plan

Test app -> src -> Test2380

Compatibility

OS Implemented
iOS
MacOS
Android
Web

@bohdanprog bohdanprog self-assigned this Sep 19, 2024
Copy link
Member

@jakex7 jakex7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

apps/test-examples/src/Test2380.tsx Outdated Show resolved Hide resolved
src/xml.tsx Outdated Show resolved Hide resolved
@bohdanprog bohdanprog changed the title feat: support css variables while parse SVG xml feat: support css variables for SvgCss Sep 19, 2024
Copy link
Member

@jakex7 jakex7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, please address that and it's good2go

src/css/css.tsx Outdated Show resolved Hide resolved
@bohdanprog
Copy link
Member Author

@jakex7 Can we merge that PR?

@bohdanprog bohdanprog requested a review from jakex7 October 2, 2024 07:13
@jakex7
Copy link
Member

jakex7 commented Oct 2, 2024

@jakex7 Can we merge that PR?

Yes

@bohdanprog bohdanprog merged commit b4dc975 into main Oct 2, 2024
3 checks passed
@bohdanprog bohdanprog deleted the @bohdanprog/support-css-variables branch October 2, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants