Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get currentColor from caller instead of parent #2521

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

jakex7
Copy link
Member

@jakex7 jakex7 commented Oct 30, 2024

Summary

Fixes #2520
When an element uses currentColor, it should look for color in its caller, not in its parent.
Example:

<Svg width="100" height="100" viewBox="0 0 100 100" color="red">
  <Defs color="blue">
    <G color="green">
      <Rect id="a" x="0" y="0" width="50" height="50" fill="currentColor"/>
    </G>
  </Defs>
  <G color="pink">
    <Use href="#a"/>												<!-- #1 -->
  </G>
  <Use href="#a" transform="translate(25 25)"/>						<!-- #2 -->
  <G color="green">
    <Use href="#a" transform="translate(50 50)"/>					<!-- #3 -->
  </G>
</Svg>
  • #1 should be pink
  • #2 should be red
  • #3 should be green

image

Test Plan

Example app -> test -> Test2520

Compatibility

OS Implemented
iOS
MacOS
Android

@jakex7 jakex7 merged commit 2a58016 into main Oct 31, 2024
7 of 9 checks passed
@jakex7 jakex7 deleted the @jakex7/fixCurrentColor branch October 31, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant