feat: update SvgPackage to supported stable API's #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address some deprecated API's in SVGPackage
jakex7
approved these changes
Nov 19, 2024
jakex7
changed the title
This was referenced Nov 19, 2024
Merged
jakex7
added a commit
that referenced
this pull request
Nov 19, 2024
# Summary #2541 is not compatible with `react-native@0.73`. This PR introduces sourceSet to maintain support for that version. ## Test Plan Build app with `react-native@0.73.x` ## Compatibility | OS | Implemented | | ------- | :---------: | | Android | ✅ |
github-merge-queue bot
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Nov 22, 2024
## Summary Replace the deprecated `TurboReactPackage` with the newer `BaseReactPackage` to improve compatibility with future React Native releases. Note that this change requires at least react-native@0.74+, but this should not be an issue as, according to the compatibility table, Reanimated@3.17.0 only supports versions 0.74 and above. Similar change has been introduced in the SVG package software-mansion/react-native-svg#2541 ## Test plan CI should pass
j-piasecki
pushed a commit
to software-mansion/react-native-gesture-handler
that referenced
this pull request
Nov 29, 2024
## Summary Replace the deprecated `TurboReactPackage` with the newer `BaseReactPackage` to improve compatibility with future React Native releases. Note that this change requires at least react-native@0.74+. Similar change has been introduced in the SVG package software-mansion/react-native-svg#2541 ## Test plan CI should pass
tjzel
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Dec 13, 2024
## Summary Replace the deprecated `TurboReactPackage` with the newer `BaseReactPackage` to improve compatibility with future React Native releases. Note that this change requires at least react-native@0.74+, but this should not be an issue as, according to the compatibility table, Reanimated@3.17.0 only supports versions 0.74 and above. Similar change has been introduced in the SVG package software-mansion/react-native-svg#2541 ## Test plan CI should pass
tjzel
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Dec 13, 2024
## Summary Replace the deprecated `TurboReactPackage` with the newer `BaseReactPackage` to improve compatibility with future React Native releases. Note that this change requires at least react-native@0.74+, but this should not be an issue as, according to the compatibility table, Reanimated@3.17.0 only supports versions 0.74 and above. Similar change has been introduced in the SVG package software-mansion/react-native-svg#2541 ## Test plan CI should pass
tjzel
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Dec 13, 2024
## Summary Replace the deprecated `TurboReactPackage` with the newer `BaseReactPackage` to improve compatibility with future React Native releases. Note that this change requires at least react-native@0.74+, but this should not be an issue as, according to the compatibility table, Reanimated@3.17.0 only supports versions 0.74 and above. Similar change has been introduced in the SVG package software-mansion/react-native-svg#2541 ## Test plan CI should pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some deprecated API's in SVGPackage
Summary
This improves compatibility with future React Native releases, which will remove TurboReactPackage and the ReactModuleInfo constructor used.
Test Plan
CI