fix: handle removed files in git status

readme.md

@@ -98,14 +98,6 @@ as you will always be prompted to create secrets if necessary. The following tab
     <td style="vertical-align: middle;">EXPO_TOKEN</td>
     <td style="vertical-align: middle;">Used for authentication in workflows using your Expo account. Learn more at <a href=https://docs.expo.dev/eas-update/github-actions>Expo with GitHub actions</a>.</td>
   </tr>
-  <tr>
-    <td style="vertical-align: middle;">GH_TOKEN</td>
-    <td style="vertical-align: middle;">
-      Used by workflows reading status of other GitHub actions. You can learn how to generate the token at 
-      <a href=https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens>Managing your personal access tokens</a>. 
-      Make sure that your generated token has <ins>read access to actions</ins>. 
-    </td>
-  </tr>
 </table>
 
 ## 💬 Your feedback

src/commands/react-native-ci-cli.ts

@@ -110,6 +110,7 @@ const runReactNativeCiCli = async (toolbox: CycliToolbox) => {
 
   const usedFlags = executorResults.join(' ')
 
+  toolbox.interactive.vspace()
   toolbox.interactive.success(`We're all set 🎉`)
 
   if (!toolbox.options.isPreset()) {

src/extensions/diff.ts

@@ -54,9 +54,11 @@ module.exports = (toolbox: CycliToolbox) => {
     let expandedPathsList: [Status, string][] = []
 
     for (const [status, path] of pathsList) {
-      const expandedPaths = await expandDirectory(
-        context.path.absFromRepoRoot(path)
-      )
+      const expandedPaths =
+        status === 'deleted'
+          ? [context.path.absFromRepoRoot(path)]
+          : await expandDirectory(context.path.absFromRepoRoot(path))
+
       expandedPathsList = expandedPathsList.concat(
         expandedPaths.map((expandedPath) => [status, expandedPath])
       )
@@ -65,7 +67,8 @@ module.exports = (toolbox: CycliToolbox) => {
     return await Promise.all(
       expandedPathsList.map(async ([status, path]: [Status, string]) => ({
         path,
-        checksum: await generateFileChecksum(path),
+        checksum:
+          status === 'deleted' ? undefined : await generateFileChecksum(path),
         status,
       }))
     ).then(
@@ -146,7 +149,7 @@ module.exports = (toolbox: CycliToolbox) => {
 
 type Status = 'added' | 'modified' | 'deleted'
 
-type Snapshot = Map<string, { checksum: string; status: Status }>
+type Snapshot = Map<string, { checksum?: string; status: Status }>
 
 type Diff = Map<
   string,

src/extensions/furtherActions.ts

@@ -19,7 +19,6 @@ module.exports = (toolbox: CycliToolbox) => {
         toolbox.interactive.info(`${S_ACTION_BULLET} ${action}`, 'cyan')
       })
       toolbox.interactive.sectionFooter({ color: 'cyan' })
-      toolbox.interactive.vspace()
     }
   }
 

src/recipes/build-release.ts

@@ -6,8 +6,12 @@ const createReleaseBuildWorkflowAndroid = async (
   context: ProjectContext,
   { expo }: { expo: boolean }
 ) => {
-  let script =
-    'cd android && ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release'
+  let script = [
+    'cd android &&',
+    './gradlew assembleRelease assembleAndroidTest',
+    '-DtestBuildType=release',
+    '-Dorg.gradle.jvmargs=-Xmx4g',
+  ].join(' ')
 
   if (expo) {
     script = `npx expo prebuild --${context.packageManager} && ${script}`

src/recipes/detox.ts

@@ -1,5 +1,5 @@
-import { REPOSITORY_SECRETS_HELP_URL } from '../constants'
 import { CycliRecipe, CycliToolbox, ProjectContext, RunResult } from '../types'
+import { addTerminatingNewline } from '../utils/addTerminatingNewline'
 import { createReleaseBuildWorkflows } from './build-release'
 import { join } from 'path'
 
@@ -34,6 +34,8 @@ const addDetoxExpoPlugin = async (toolbox: CycliToolbox) => {
         return config
       })
 
+      addTerminatingNewline(appJsonFile)
+
       toolbox.interactive.step(`Added ${DETOX_EXPO_PLUGIN} plugin to app.json`)
     }
   }
@@ -118,13 +120,6 @@ const createDetoxWorkflows = async (
   await toolbox.workflows.generate(join('detox', 'test-detox-ios.ejf'), context)
 
   toolbox.interactive.success('Created Detox workflow.')
-
-  toolbox.interactive.warning(
-    `Remember to create GH_TOKEN repository secret to make Detox workflow work.For more information check ${REPOSITORY_SECRETS_HELP_URL} `
-  )
-  toolbox.furtherActions.push(
-    `Create GH_TOKEN repository secret.More info at ${REPOSITORY_SECRETS_HELP_URL} `
-  )
 }
 
 const execute =

src/recipes/jest.ts

@@ -14,7 +14,7 @@ const execute =
 
     await toolbox.dependencies.addDev('jest', context)
 
-    await toolbox.scripts.add('test', 'jest')
+    await toolbox.scripts.add('test', 'jest --passWithNoTests')
 
     if (!existsJestConfiguration(toolbox)) {
       await toolbox.template.generate({

src/recipes/prettier.ts

@@ -3,7 +3,11 @@ import { join } from 'path'
 
 export const FLAG = 'prettier'
 
-const PRETTIER_CONFIGURATION_FILES = ['.prettierrc', 'prettier.config.js']
+const PRETTIER_CONFIGURATION_FILES = [
+  '.prettierrc',
+  'prettierrc.json',
+  'prettier.config.js',
+]
 
 const existsPrettierConfiguration = (toolbox: CycliToolbox): boolean =>
   Boolean(toolbox.projectConfig.packageJson().prettier) ||

src/templates/detox/test-detox-android.ejf

@@ -29,7 +29,7 @@ jobs:
       - name: ⌛ Wait for build to finish
         uses: poseidon/wait-for-status-checks@v0.5.0
         with:
-          token: ${{ secrets.GH_TOKEN }}
+          token: ${{ secrets.GITHUB_TOKEN }}
           delay: 20s
           match_pattern: build-release-android
 

src/templates/detox/test-detox-ios.ejf

@@ -27,7 +27,7 @@ jobs:
       - name: ⌛ Wait for build to finish
         uses: poseidon/wait-for-status-checks@v0.5.0
         with:
-          token: ${{ secrets.GH_TOKEN }}
+          token: ${{ secrets.GITHUB_TOKEN }}
           delay: 20s
           match_pattern: build-release-ios