fix(): add missing react useEffect hook dependencies

softwaremill · Jul 21, 2022 · a1b7947 · a1b7947
1 parent b99e391
commit a1b7947
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ui/src/pages/Login/Login.tsx b/ui/src/pages/Login/Login.tsx
@@ -30,7 +30,7 @@ export const Login: React.FC = () => {
 
   useEffect(() => {
     if (loggedIn) navigate("/main");
-  }, [loggedIn]);
+  }, [loggedIn, navigate]);
 
   return (
     <TwoColumnHero>

diff --git a/ui/src/pages/Register/Register.tsx b/ui/src/pages/Register/Register.tsx
@@ -34,7 +34,7 @@ export const Register: React.FC = () => {
 
   React.useEffect(() => {
     if (loggedIn) navigate("/main");
-  }, [loggedIn]);
+  }, [loggedIn, navigate]);
 
   return (
     <TwoColumnHero>