More user friendly error messages #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2020 17:08
* Login and ChangePassword operations returns Unauthorized in case of unknown user instead of NotFound
adamw
reviewed
Oct 22, 2020
| _ = logger.debug(s"Changing password for user: $userId") | ||
| _ <- userModel.updatePassword(userId, User.hashPassword(newPassword)) | ||
| } yield () | ||
|
|
||
| private def userOrNotFound(op: ConnectionIO[Option[User]]): ConnectionIO[User] = { | ||
| op.flatMap { | ||
| case Some(user) => user.pure[ConnectionIO] | ||
| case None => Fail.NotFound("user").raiseError[ConnectionIO, User] | ||
| case None => Fail.Unauthorized("Incorrect login/email or password").raiseError[ConnectionIO, User] |
There was a problem hiding this comment.
We should probably extract this message to a constant so that it's not repeated, and the fact that the constant is used twice will also be informative for the developer
adamw
reviewed
Oct 22, 2020
| @@ -27,7 +27,7 @@ class PasswordResetService( | |||
|
|
|||
| def forgotPassword(loginOrEmail: String): ConnectionIO[Unit] = { | |||
| userModel.findByLoginOrEmail(loginOrEmail.lowerCased).flatMap { | |||
| case None => Fail.NotFound("user").raiseError[ConnectionIO, Unit] | |||
| case None => ().pure[ConnectionIO] | |||
There was a problem hiding this comment.
maybe add a debug-log so that it's visible in the logs that the user hasn't been found? (as it's not visible in the UI)
adamw
approved these changes
Oct 22, 2020
* Adding log message if user can't be found during forgotPassword operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #439
More user friendly error messages