-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm public repo #470
Helm public repo #470
Conversation
@@ -3,3 +3,6 @@ chart-dirs: | |||
- helm | |||
chart-repos: | |||
- bitnami=https://charts.bitnami.com/bitnami | |||
debug: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this stay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this setup will duplicated across all SoftwareMill repositories / projects for which Helm Charts exist - currently around 30 SML applications (both internal and open-source) are deployed using Helm; so this is just for additional diagnostic info, it simply outputs additional info during the "Run chart-testing (lint)" (e.g. https://github.com/softwaremill/bootzooka/runs/1447485540?check_suite_focus=true) and "Run chart-testing (install)" (e.g. https://github.com/softwaremill/bootzooka/runs/1447487632?check_suite_focus=true) jobs; I can remove this setting now if you insist, but IMHO we should leave it until we have this implemented across several setups in case any changes are needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I was wondering if it's not a left-over from dev
@@ -0,0 +1,45 @@ | |||
<svg xmlns="http://www.w3.org/2000/svg" width="874" height="472" viewBox="0 0 874 472" xmlns:xlink="http://www.w3.org/1999/xlink"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need the svg banner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for Helm repository aggregator (https://artifacthub.io/) to which SoftwareMill Helm Repository will be added shortly - as you know, vector graphics (SVG is such) can scale with no loss, and having banner.png (raster) could have resulted in distortion/unreadable rendering. so just for quality purposes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but we should keep one. These banners change sometimes and maintaining two is unnecessary work
@@ -17,6 +17,33 @@ To build a docker image, run `backend/docker:publishLocal`. This will create the | |||
|
|||
You can test the image by using the provided `docker-compose.yml` file. | |||
|
|||
|
|||
## Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good docs, thanks! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Added Helm Chart documentation; re-factored / improved workflow - added testing with multiple Kubernetes versions via matrix strategy and Helm Chart documentation validation to ensure it's up to date; added publishing Helm Chart automatically to SoftwareMill Helm Chart repository upon successful run of all prerequisite validation steps