Deploy on GH release event #640
Conversation
| paths-ignore: | ||
| - "helm/**" | ||
|
|
||
| jobs: | ||
| scala-ts-tests: | ||
| # run on external PRs, but not on internal PRs since those will be run by push to branch | ||
| if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository |
There was a problem hiding this comment.
this was quite useful as when we were doing PRs from branches in this repository (not from forks), we got double builds (one for the PR, one for the in-repository branch). Is this problem solved somehow else?
There was a problem hiding this comment.
Sure, but please note I also added explicite branch name in on:.
So now this workflow is triggered:
- on push to master branch
- on PR (create, update etc)
- on GH release.
So no double builds (unless unlikely event when someone creates PR with master as source branch)
build.sbt
Outdated
| @@ -156,29 +155,24 @@ lazy val fatJarSettings = Seq( | |||
| } | |||
| ) | |||
|
|
|||
| git.uncommittedSignifier := Some("dirty") | |||
There was a problem hiding this comment.
if these settings are used only for docker build, maybe we can scope and move them to dockerSettings?
There was a problem hiding this comment.
Done, please check it now.
|
I think we should automatically create a GH release, once a version-tag is pushed? We have this set up using release-drafter in other projects, so maybe we can do the same here? E.g. https://github.com/softwaremill/quicklens/blob/master/.github/workflows/ci.yml#L80-L89 |
No description provided.