Tapir based secuirty #794
Tapir based secuirty #794
Conversation
|
closes #769 |
|
closes #793 |
| .in(jsonBody[ChangePassword_IN]) | ||
| .out(jsonBody[ChangePassword_OUT]) | ||
| .serverLogic { case (authData, data) => | ||
| .serverSecurityLogic(authData => auth.applyEither(authData).map(_.left.map(exceptionToErrorOut))) |
There was a problem hiding this comment.
can't we use .toOut here as for server logic?
There was a problem hiding this comment.
Not if I understand it correctly here we just mapping left while .toOut perform mapping on both left and right, in fact .toOut maps whole IO[] we just need to map the left of Either
There was a problem hiding this comment.
I didn't understand correctly fixed
| (for { | ||
| _ <- userService.changePassword(id, data.currentPassword, data.newPassword).transact(xa) | ||
| } yield ChangePassword_OUT()).toOut | ||
| ) | ||
|
|
||
| private val getUserEndpoint = secureEndpoint.get | ||
| .in(UserPath) |
There was a problem hiding this comment.
if changePasswordEndpoint uses .securityIn for the path, shouldn't we use this here as well?
There was a problem hiding this comment.
Now I am not sure if changePasswordEndpoint require path in .securityIn , which way is better in your opinion ?
There was a problem hiding this comment.
yeah you're right it's fine to keep them all in the regular inputs. The path matching is done on both anyway
|
Thanks :) |
|
@Pask423 so right now postgres is run through a container? |
No description provided.