Parse test reports in the GH Actions workflow #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! How come we didn't have this before? ;) |
adamw
reviewed
Nov 23, 2023
.github/workflows/ci.yml
Outdated
| @@ -23,6 +23,13 @@ jobs: | |||
| run: sbt -v compile | |||
| - name: Test | |||
| run: sbt -v test | |||
| - name: Test Report | |||
| uses: dorny/test-reporter@v1 | |||
| if: success() || failure() | |||
There was a problem hiding this comment.
isn't this a no-op? that is, can't we simply remove this?
There was a problem hiding this comment.
No, it means to run this step regardless if the previous one failed or succeeded. Without it test reports wouldn'd be parsed if any test failed.
There was a problem hiding this comment.
Ah ok :) maybe add a comment, I think people might find it confusing (e.g. me ;) )
|
Thanks! |
adamw
pushed a commit
to softwaremill/tapir
that referenced
this pull request
Nov 28, 2023
Adds `Tests results` section in `Checks` which layouts test results in eye-friendly manner.  Based on: softwaremill/ox#53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "Test results" under the jobs in the workflow:
Makes it easier to find failed tests and presents nice overview of all the tests run