-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for jsoniter Json #1248
Conversation
Offtopic; I also updated the openApi generator to use sttp3. |
json/jsoniter/src/main/scala/sttp/client3/jsoniter/SttpJsoniterJsonApi.scala
Outdated
Show resolved
Hide resolved
Could you merged newest master, it should solve problem with js tests. |
I see one big problem with jsoniter and sttp and that is that sttp uses either and option a lot. So i think jsoniter needs to be improved for our usecase. |
Refactored code added option def to jsonIterApi
That can be quite problematic from user perspective. I am not that familiar with jsoniter to propose any workaround for this. |
I could only make a workaround for 'option[t]'. For Either i couldn't really make a good workaround. So we might better close the pr and maybe we can best keep the github issue open and comment these issues on there for future reference? |
Hm I don't think we need any special |
Removed tests that are expect ambiguas either objects.
I've removed the ambiguous Either tests and now i expect the use of |
json/jsoniter/src/main/scala/sttp/client3/jsoniter/SttpJsoniterJsonApi.scala
Outdated
Show resolved
Hide resolved
Great just resolve conflicts and I think we can merge it |
scala 3 macro support still needs to be added. I'll remove scala3 from the possible builds. |
Before submitting pull request:
sbt compile
sbt compileDocs
sbt test
sbt scalafmt