Updates for ZIO 2.0.0-RC5 #1410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unclear to me if the docs should be updated for ZIO 2 or should be left on ZIO 1 |
desavitsky
reviewed
Apr 14, 2022
| @@ -49,11 +49,13 @@ object ArmeriaZioBackend { | |||
| .runtime[Any] | |||
| .map(runtime => apply(runtime, newClient(options), closeFactory = true)) | |||
|
|
|||
| def managed(options: SttpBackendOptions = SttpBackendOptions.Default): TaskManaged[SttpBackend[Task, ZioStreams]] = | |||
| ZManaged.acquireReleaseWith(apply(options))(_.close().ignore) | |||
| def managed( | |||
There was a problem hiding this comment.
Does it have sense calling it managed? Maybe rename it to scoped?
There was a problem hiding this comment.
I had the same thought. Happy to change it if we think that's a better name.
There was a problem hiding this comment.
Softwaremill folks make a decision and let me know what you want to see here. Happy to make the changes or leave it as is.
|
Thanks, though closing in favor of #1407 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting pull request:
sbt compilesbt compileDocssbt testsbt scalafmt