General OpenTelemetry backend #1411
Conversation
.../open-telemetry-backend/src/main/scala/sttp/client3/opentelemetry/OpenTelemetryBackend.scala
Outdated
Show resolved
Hide resolved
.../open-telemetry-backend/src/main/scala/sttp/client3/opentelemetry/OpenTelemetryBackend.scala
Outdated
Show resolved
Hide resolved
| private implicit val _monad: MonadError[F] = responseMonad | ||
| type PE = P with Effect[F] | ||
|
|
||
| def send[T, R >: PE](request: Request[T, R]): F[Response[T]] = { |
There was a problem hiding this comment.
the impl looks quite different from the zio one, but I suspect that's beacuse the zio library was doing some of the work that happens here? I'm not familiar with other opentelemetry integrations, if that's what is usually done, fine :)
There was a problem hiding this comment.
I used example from io.opentelemetry.api.trace.Tracer class with automatic context propagation it seemed reasonable
.../open-telemetry-backend/src/main/scala/sttp/client3/opentelemetry/OpenTelemetryBackend.scala
Outdated
Show resolved
Hide resolved
.../open-telemetry-backend/src/main/scala/sttp/client3/opentelemetry/OpenTelemetryBackend.scala
Outdated
Show resolved
Hide resolved
Pask423
changed the title
.../open-telemetry-backend/src/main/scala/sttp/client3/opentelemetry/OpenTelemetryBackend.scala
Outdated
Show resolved
Hide resolved
.../open-telemetry-backend/src/main/scala/sttp/client3/opentelemetry/OpenTelemetryBackend.scala
Outdated
Show resolved
Hide resolved
.../open-telemetry-backend/src/main/scala/sttp/client3/opentelemetry/OpenTelemetryBackend.scala
Outdated
Show resolved
Hide resolved
|
|
||
| private def prepareBaseAttributes[R >: PE, T](request: Request[T, R]) = { | ||
| Attributes.of( | ||
| AttributeKey.stringKey("http.method"), |
There was a problem hiding this comment.
aren't these keys available via SemanticAttributes ?
Also, why do we set the method & url, but not the target, scheme, host, etc?
There was a problem hiding this comment.
you are sure that SemanticAttributes are reachable from this project ?
I decide to set same params as for opentracingbackend
There was a problem hiding this comment.
no, I saw the constant in the docs, maybe it's not in the api
though the example in the docs for a http client call sets only method & url, so maybe that's standard
.../open-telemetry-backend/src/main/scala/sttp/client3/opentelemetry/OpenTelemetryBackend.scala
Outdated
Show resolved
Hide resolved
|
Reading through https://opentelemetry.io/docs/instrumentation/java/manual/, I see that there's also a metrics api. Maybe we should have both an |
|
Why not I will make it in separate PR. |
|
@Pask423 looks good. Fine with a separate PR and removing open tracing :) |
closes #1402