Fix PUT method in CurlBackend #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently PUT is not working because deprecated flags are being used in calls to libcurl.
|
More information about the deprecation #6186 |
Pask423
approved these changes
Apr 29, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a CLI interface with Scala Native that issues request to an HTTP server, with the unfortunate luck that the first use case is a PUT request with body. Using CurlBackend for this scenario leaves the client completely frozen (I guess some C internals that I don't understand).
Looks like it's not working because deprecated flags are being used in calls to
libcurl. Following the recommended example in httpput-postfields it's clear that we need to use a custom request.